GNOME Bugzilla – Bug 531215
"open your flickr gallery in browser" button
Last modified: 2021-05-17 16:15:40 UTC
I would like to see this button in main Postr's window to make my life comfortable (what an egoist :D ).
Created attachment 148371 [details] [review] Open your flickr gallery with a button in main Postr's window Open your flickr gallery with a button in main Postr's window
Created attachment 148373 [details] [review] Open your flickr gallery with a button in main Postr's window sorry, wrong file. I hope this time is the correct file =)
(In reply to comment #2) > Created an attachment (id=148373) [details] [review] > Open your flickr gallery with a button in main Postr's window > > sorry, wrong file. I hope this time is the correct file =) (In reply to comment #2) > Created an attachment (id=148373) [details] [review] > Open your flickr gallery with a button in main Postr's window > > sorry, wrong file. I hope this time is the correct file =)
Review of attachment 148373 [details] [review]: Thanks Juan for your work. I don't know if the button is in the best possition, IMHO is better add a menuitem in the menu bar like "Go" -> "Open Flickr Gallery" instead of a button. ::: src/postr.py @@ -476,2 +477,4 @@ self.update_statusbar() - + + def on_open_gallery(self, widget): + url = "http://www.flickr.com/photos/" + self.flickr.username The 'http://www.flickr.com/photos/' + username isn't necessary the url for the gallery. It should use self.flickr.get_nsid() instead
Created attachment 148430 [details] [review] Open your flickr gallery with a button in main Postr's window or menu item in the menu bar "File" in the menu bar "File" I think the button is fine but I added it as menu item in the menu bar "File" like add and remove item =)
Created attachment 148502 [details] [review] Open your flickr gallery with a menu item in the menu bar "Go" well, finally two friends said me that put this feature in the menu bar "Go", so I did it :P
Review of attachment 148502 [details] [review]: ::: src/postr.glade @@ +195,3 @@ + <property name="use_underline">True</property> + <property name="use_stock">True</property> + <signal name="activate" handler="on_open_gallery_activate"/> Check if the menu item is meaningful enough for its icon to be always shown, I guess it's not that important. Remember the new default is to only enforce icons in menus for stuff that really needs it. Try your patch with icons-in-menus disabled (see in preferences > appearance) Label should be "Go to flickr gallery" or something, I'm unsure how flickr calls the /photos/username pages. ::: src/postr.py @@ +480,3 @@ + url = "http://www.flickr.com/photos/" + self.flickr.get_nsid() + gtk.show_uri(None, url, gtk.gdk.CURRENT_TIME) + You can use gtk.get_current_event_time() instead of gtk.gdk.CURRENT_TIME. And a minor nitpick: flickr calls itself flickr.com without the www I think.
Created attachment 148675 [details] [review] display a dialog after upload operation w/links to further actions I found that I wanted to view my photostream or visit flickr in general mostly just after an upload operation. This patch includes a dialog after uploads complete (either successfully or w/a failure) with links to the organize most recent upload and view photostream pages. I find that this also solves a small communication issue that I felt needed resolving, which was that the upload progress dialog would just disappear w/o any sort of finished response.
Review of attachment 148502 [details] [review]: Diego made valid comments. Please, update the patch with Diego's comments in mind.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/postr/-/issues/4.