After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529789 - Take Picture button is enabled outside gtk thread lock
Take Picture button is enabled outside gtk thread lock
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-04-24 21:59 UTC by Gary Lasker
Modified: 2008-04-25 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to move enabling Take Picture button inside the gtk thread lock (449 bytes, patch)
2008-04-24 22:02 UTC, Gary Lasker 		accepted-commit_now Details | Review

Description Gary Lasker 2008-04-24 21:59:54 UTC 
Please describe the problem:
Inside the camera setup thread, some UI updates are done using gdk_threads_enter/leave().  However, the call to enable the Take Picture button currently occurs *after* gdk_threads_leave(), so it is occurring outside the gtk thread lock.

It's a very simple fix.  I'll attach a patch against SVN.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Gary Lasker 2008-04-24 22:02:12 UTC 
Created attachment 109862 [details] [review]
Patch to move enabling Take Picture button inside the gtk thread lock
Comment 2 daniel g. siegel 2008-04-25 01:10:40 UTC 
thanks! please commit it ;)
Comment 3 Gary Lasker 2008-04-25 15:58:02 UTC 
Thanks Daniel!  I don't have commit access, could somebody please commit this for me?  Thanks, I appreciate it!
Comment 4 daniel g. siegel 2008-04-25 16:15:07 UTC 
commited to trunk/ thanks!