After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526006 - migrate invest-applet from gnome-vfs to gio
migrate invest-applet from gnome-vfs to gio
Product: gnome-applets
Classification: Other
Component: invest-applet
git master
Other All
: High minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 543712 (view as bug list)
Depends on: 544777
Reported: 2008-04-03 16:43 UTC by Matteo Zandi
Modified: 2008-08-18 07:26 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

use urllib.urlopen with threads instead of async (20.93 KB, patch)
2008-05-18 19:36 UTC, Matteo Zandi
committed Details | Review

Description Matteo Zandi 2008-04-03 16:43:59 UTC
gnome-vfs is going to be deprecated, migrate invest-applet code to gio/gvfs

Other information:
Comment 1 Matteo Zandi 2008-05-18 19:36:43 UTC
Created attachment 111114 [details] [review]
use urllib.urlopen with threads instead of async

This patch removes gnomevfs depencency and adds the following features:
- use tooltip to communicate if invest fails to connect yahoo finance, give some brief information about stocks/positions
- proxy support (use gnome proxy settings if valid, otherwise use system proxy)

Closes also:
- #415237 – invest applets does not retrieve quotes (proxy)

I have no possibility to test the proxy feature, it would be nice to have feedbacks.
Comment 2 André Klapper 2008-07-28 11:56:38 UTC
*** Bug 543712 has been marked as a duplicate of this bug. ***
Comment 3 André Klapper 2008-07-28 11:56:53 UTC
Opened by Andre Klapper (reporter, points: 29)
2008-07-19 10:30 UTC [reply]

Also see for more information.
Copying from duplicate bug 543712:

./invest-applet/invest/ gnomevfs
./invest-applet/invest/      , lambda
h,e: self.on_chart_open(h,e,url))
./invest-applet/invest/, open_cb,
./invest-applet/invest/                gnomevfs.PRIORITY_DEFAULT)
./invest-applet/invest/ gtk, gobject, gnomevfs
./invest-applet/invest/      % {"s": s[:-1]}, self.on_quotes_open)
./invest-applet/invest/ gtk, gobject, gnomevfs
./invest-applet/invest/ gtk, gtk.gdk, gnomevfs, gobject
./invest-applet/invest/        gnomevfs.url_show("mailto:%s" % mail)
./invest-applet/invest/        gnomevfs.url_show(link)

Comment #1 from Gian Mario Tagliaretti:

In order to completely remove gnomevfs also an unstable release of pygtk is
needed (for gtk_show_uri), I already have a patch for pygtk, I hope I can
finish it in a few days and roll a patch for invest-applet afterwards.

Comment 4 André Klapper 2008-07-28 12:01:16 UTC
Callum, can we get a review/commit if possible? TIA!
Comment 5 André Klapper 2008-08-10 22:31:52 UTC
OK, pygtk API is in, see bug 544777. Now we only need a pygtk release...
Comment 6 Callum McKenzie 2008-08-15 00:53:02 UTC
The patch has numerous minor issues. I hope to be able to merge and fix the patch in the next few days. The most notable issue is that the retrieval of the stock data is not done asynchronously (only the opening of the socket). This should be almost trivial for me to fix.
Comment 7 Callum McKenzie 2008-08-17 00:17:51 UTC
The patch has been fixed and committed.
Comment 8 André Klapper 2008-08-17 05:00:48 UTC
Great, thanks everybody! Matteo, also interested in porting disk-mounter (bug 543711)? ;-)
Comment 9 Matteo Zandi 2008-08-18 07:26:09 UTC
I'm sorry but I have no time in this period and I still have some other changes in mind for invest-applet :)