Bug 523914 - large compositor shadow is not centered vertically
large compositor shadow is not centered vertically
Status: RESOLVED NOTABUG
Product: metacity
Classification: Other
Component: Iain's compositor
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: iain
Metacity compositor maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-03-22 22:43 UTC by Björn Martensen
Modified: 2008-03-30 02:15 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Björn Martensen 2008-03-22 22:43:53 UTC 
the new metacity 2.23.5 introduces a larger drop shadow for the focused window, which i like a lot, but this larger drop shadow is not centered correctly, which looks bad, imho.

the current shadow is larger on the right side of the window than on the left side, but i think it should be centered vertically, such as the smaller shadow is.

i'd even move it a bit to the bottom, but at least center it vertically, please!
Comment 1 Björn Martensen 2008-03-22 22:44:45 UTC 
i meant 2.23.3 of course..
Comment 2 Thomas Thurman 2008-03-23 22:43:50 UTC 
I'm merging this with the very similar bug 521465 so we can discuss both in the same place.

*** This bug has been marked as a duplicate of 521465 ***
Comment 3 iain 2008-03-24 01:19:17 UTC 
I'm reopening this as its really a different issue to 521465
Comment 4 iain 2008-03-24 01:22:15 UTC 
The shadow offset can be changed in the compositor.c file, its just a define at the top, but yeah, the light comes from the top left, so shadows are cast bottom-right. I like the light cast from the top so shadows are horizontally centred, but if you do that far too many people complain...
Comment 5 Andrea Cimitan 2008-03-30 01:44:20 UTC 
since Clearlooks theme source light position is topleft (highlight, insets on buttons, shadows etc etc) having the same behaviour is good.

So I'm for the actual behaviour.
Comment 6 Thomas Thurman 2008-03-30 02:14:36 UTC 
It's not just Clearlooks: this convention is near-universal, and for a reason.

See http://www.shadedrelief.com/retro/discussion.html .

Marking INVALID.
Comment 7 Thomas Thurman 2008-03-30 02:15:42 UTC 
...er, NOTABUG, sorry.
Note You need to log in before you can comment on or make changes to this bug.