After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523737 - Unconditional passing of G_DISABLE_DEPRECATED and co even in stable versions
Unconditional passing of G_DISABLE_DEPRECATED and co even in stable versions
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-21 21:30 UTC by Mart Raudsepp
Modified: 2008-05-29 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Mart Raudsepp 2008-03-21 21:30:09 UTC 
gnome-terminal currently passes -DGDK_DISABLE_DEPRECATED and -DG_DISABLE_DEPRECATED in src/Makefile.am currently. This will probably break for the future, but stable versions ought to not break.
I suggest only defining *_DISABLE_DEPRECATED macros in development versions (SVN and odd minor version number), not stable releases.
gnome-terminal-2.18 already broke compilation with the upgrade to glib-2.16 for instance - it has to keep compiling, I had to inplace sed the -DG_DISABLE_DEPRECATED out from Makefile.am and Makefile.in for that.

I'd appreciated this fixed for future versions of 2.22 and in trunk, so I can remove the ugly sed.
Comment 1 Mart Raudsepp 2008-03-21 21:32:03 UTC 
There's also the possibility of using GNOME_MAINTAINER_MODE_DEFINES from gnome-common.m4 for this, that adds all DISABLE_DEPRECATES when enabled in configure. I just can't remember if using it was encouraged or discouraged...
Comment 2 Christian Persch 2008-03-25 11:58:12 UTC 
GNOME_MAINTAINER_MODE_DEFINES is the best way.
Comment 3 Christian Persch 2008-05-29 21:34:54 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.