GNOME Bugzilla – Bug 520523
[API] Unreviewed changes to ringbuffer API
Last modified: 2008-03-12 12:40:04 UTC
The new ringbuffer GstBufferFormatType value: GST_BUFTYPE_NONLINEAR makes no sense to me.
NONLINEAR is the wrong name for multiple reasons - most of the other buffer types there are nonlinear in one way or another. Perhaps the intended meaning was something about block-based compression?
But there are several existing block-based, compressed, buffer types there.
I think these should just be added individually - GST_BUFTYPE_IEC958, GST_BUFTYPE_AC3, etc.
The implementation has some issues too, but it's a step in the right direction, and isn't a regression, so shouldn't block a release.
Created attachment 106766 [details] [review]
Patch to rename new enum values
Ok! Here's your patch.
Julien, do you have any objections to these changes?
Nope, no objections.
2008-03-12 Michael Smith <email@example.com>
* gst-libs/gst/audio/gstringbuffer.c: (gst_ring_buffer_parse_caps):
Rename recently added buffer types to make more sense.
* ext/alsa/gstalsasink.c: (alsasink_parse_spec),
Adapt for above API changes.
Fixes bug #520523.