After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520523 - [API] Unreviewed changes to ringbuffer API
[API] Unreviewed changes to ringbuffer API
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2008-03-05 14:42 UTC by Michael Smith
Modified: 2008-03-12 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch to rename new enum values (3.08 KB, patch)
2008-03-07 11:28 UTC, Michael Smith
committed Details | Review

Description Michael Smith 2008-03-05 14:42:04 UTC
The new ringbuffer GstBufferFormatType value: GST_BUFTYPE_NONLINEAR makes no sense to me.

NONLINEAR is the wrong name for multiple reasons - most of the other buffer types there are nonlinear in one way or another. Perhaps the intended meaning was something about block-based compression?

But there are several existing block-based, compressed, buffer types there.

I think these should just be added individually - GST_BUFTYPE_IEC958, GST_BUFTYPE_AC3, etc.

The implementation has some issues too, but it's a step in the right direction, and isn't a regression, so shouldn't block a release.
Comment 1 Jan Schmidt 2008-03-07 10:43:31 UTC
Patch please!
Comment 2 Michael Smith 2008-03-07 11:28:20 UTC
Created attachment 106766 [details] [review]
Patch to rename new enum values

Ok! Here's your patch.
Comment 3 Jan Schmidt 2008-03-10 23:32:00 UTC
Julien, do you have any objections to these changes?
Comment 4 Julien MOUTTE 2008-03-12 00:40:51 UTC
Nope, no objections.
Comment 5 Jan Schmidt 2008-03-12 10:01:32 UTC
Comment 6 Michael Smith 2008-03-12 12:40:04 UTC
2008-03-12  Michael Smith <>

    * gst-libs/gst/audio/gstringbuffer.c: (gst_ring_buffer_parse_caps):
    * gst-libs/gst/audio/gstringbuffer.h:
      Rename recently added buffer types to make more sense.
    * ext/alsa/gstalsasink.c: (alsasink_parse_spec),
      Adapt for above API changes.
      Fixes bug #520523.