GNOME Bugzilla – Bug 520269
Possibly incorrect use of plurals
Last modified: 2008-03-12 00:59:51 UTC
From the current POT file: #: ../gcalctool/gtk.c:546 msgid "Set accuracy from 0 to %d numeric places." msgid_plural "Set accuracy from 0 to %d numeric places." #: ../gcalctool/gtk.c:552 msgid "Currently set to %d places." msgid_plural "Currently set to %d places." The singular and plural cases are the same, and I don't think this is correct. Surely the singular should be "place"? The second quoted message will result in something like "Currently set to 1 places" - is this perhaps intended?
The first one is correct as it giving a range and the second value is always greater than 1. The second one is part of an ngettext call: current = g_strdup_printf(ngettext("Currently set to %d places.", "Currently set to %d places.", accuracy), accuracy); that is incorrect. The first string should say "Currently set to %d place.". We are in final freeze for the GNOME 2.22 release, so it's too late to fix it for gcalctool 5.22.0. We'll make sure that it's addressed for the next development release. Thanks.
Thanks for the feedback. In the first case I think a comment might help to avoid repeat questions. Should the second one perhaps be fixed in the English locale for the 2.22 release? That way it should at least appear correct for users having their systems set to English, as far as I understand. Thanks again.
We can certainly add a comment to the first string to reduce confusion. Again, this will be in the next development cycle. For the second string: We are in a Hard Code Freeze: http://live.gnome.org/ReleasePlanning/Freezes "no source code changes can be made without approval from the release-team." I really don't want to bother them for what it really a trivial problem.
Created attachment 107008 [details] [review] Patch to fix the problems.
Patch committed to gcalctool SVN trunk. The fix will turn up in the first tarball for the gcalctool included in the GNOME 2.23.X series. Closing as FIXED.
Rich, this patch appears to have been committed to the 2.22 branch and not the head...
> Rich, this patch appears to have been committed to the 2.22 branch and not the > head... Are you sure? See: http://svn.gnome.org/viewvc/gcalctool/branches/gnome-2-22/gcalctool/gtk.c?view=log and http://svn.gnome.org/viewvc/gcalctool/trunk/gcalctool/gtk.c?view=log And for the latter, revision 2019: http://svn.gnome.org/viewvc/gcalctool?view=revision&revision=2019
Sorry, I missed the logic there - one ngettext has been _removed_ because it is not necessary...