After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519916 - [API] add mixer-changed and options-list-changed messages
[API] add mixer-changed and options-list-changed messages
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-02 15:15 UTC by Tim-Philipp Müller
Modified: 2008-03-03 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add proposed API and docs and unit test bits (9.78 KB, patch)
2008-03-02 15:15 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2008-03-02 15:15:05 UTC
I would like to changed message types to the current mixer changed message API, namely:

  GST_MIXER_MESSAGE_OPTIONS_LIST_CHANGED
  GST_MIXER_MESSAGE_MIXER_CHANGED

plus associated post and parse functions (no parse for mixer-changed since there's no additional data with that).

This is useful for mixer implementations where the mixer options list can change over time, and/or where the entire mixer layout can change over time (e.g. in response to an option being changed). This is the case with OSS4, for example.

Patch with unit test and docs attached.
Comment 1 Tim-Philipp Müller 2008-03-02 15:15:46 UTC
Created attachment 106390 [details] [review]
Add proposed API and docs and unit test bits
Comment 2 Tim-Philipp Müller 2008-03-03 14:00:36 UTC
Committed after short discussion on IRC:

 2008-03-03  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/libs/gst-plugins-base-libs-sections.txt:
        * gst-libs/gst/interfaces/mixer.c: (gst_mixer_option_changed),
          (gst_mixer_options_list_changed), (gst_mixer_mixer_changed),
          (gst_mixer_message_get_type),
          (gst_mixer_message_parse_option_changed),
          (gst_mixer_message_parse_options_list_changed):
        * gst-libs/gst/interfaces/mixer.h: (GstMixerType),
          (GST_MIXER_MESSAGE_OPTION_CHANGED),
          (GST_MIXER_MESSAGE_OPTIONS_LIST_CHANGED),
          (GST_MIXER_MESSAGE_MIXER_CHANGED):
          API: add gst_mixer_options_list_changed(), gst_mixer_mixer_changed()
          and gst_mixer_message_parse_options_list_changed(). Fixes #519916.

 2008-03-03  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/libs/mixer.c:
          Add a few simple checks for the new message types.