GNOME Bugzilla – Bug 518940
[playbin2] make _get_*_tags() match vfuncs prototype in class structure
Last modified: 2008-03-03 19:51:53 UTC
Hello. This enhancement request depends on bug #518934 (also an enhancement request). If #518934 is accepted would you also accept the attached patch that would ensure good gst-plugins-base compilation? Thanks.
Created attachment 106031 [details] [review]
Patch to ensure good gst-plugins-base compilation
Created attachment 106037 [details] [review]
Regenerated patch (with cvs diff -u -p)
This seems to be the right thing to do regardless:
2008-03-02 Tim-Philipp Müller <tim at centricular dot net>
Patch by: José Alburquerque <jaalburqu svn gnome org>
Make the function signature of the _get_*_tags() functions match
the signature of the vfuncs they implement, ie. return a
GstTagList rather than a GstStructure, which is more correct,
even if one is typedef'ed to the other (#518940).
Thanks for the patch!
My pleasure. :-)