After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518940 - [playbin2] make _get_*_tags() match vfuncs prototype in class structure
[playbin2] make _get_*_tags() match vfuncs prototype in class structure
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2008-02-26 22:29 UTC by José Alburquerque
Modified: 2008-03-03 19:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Patch to ensure good gst-plugins-base compilation (704 bytes, patch)
2008-02-26 22:30 UTC, José Alburquerque
none Details | Review
Regenerated patch (with cvs diff -u -p) (1.04 KB, patch)
2008-02-27 00:21 UTC, José Alburquerque
committed Details | Review

Description José Alburquerque 2008-02-26 22:29:07 UTC
Hello.  This enhancement request depends on bug #518934 (also an enhancement request).  If #518934 is accepted would you also accept the attached patch that would ensure good gst-plugins-base compilation?  Thanks.
Comment 1 José Alburquerque 2008-02-26 22:30:57 UTC
Created attachment 106031 [details] [review]
Patch to ensure good gst-plugins-base compilation
Comment 2 José Alburquerque 2008-02-27 00:21:24 UTC
Created attachment 106037 [details] [review]
Regenerated patch (with cvs diff -u -p)
Comment 3 Tim-Philipp Müller 2008-03-02 18:43:22 UTC
This seems to be the right thing to do regardless:

 2008-03-02  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: José Alburquerque <jaalburqu svn gnome org>

        * gst/playback/gstplaybin2.c:
          Make the function signature of the _get_*_tags() functions match
          the signature of the vfuncs they implement, ie. return a
          GstTagList rather than a GstStructure, which is more correct,
          even if one is typedef'ed to the other (#518940).

Thanks for the patch!
Comment 4 José Alburquerque 2008-03-03 19:51:53 UTC
My pleasure. :-)