After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516846 - Use short labels in toolbar
Use short labels in toolbar
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 541422 548080 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-16 13:28 UTC by Luca Ferretti
Modified: 2013-06-14 22:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The proposed patch (6.45 KB, patch)
2008-02-16 13:29 UTC, Luca Ferretti 		committed Details | Review

Description Luca Ferretti 2008-02-16 13:28:42 UTC 
HIG requests to keep the toolbar button labels "as short as possible, preferably a single verb."[1]

Here is a patch to add "short-label" properties to:
 * clear action in play queue
 * new and update all in podcast
 * copy to library in removable (changing to Extract to match Sound Juicer)
 * burn in cd recorder
 * new in iRadio
 * next, love and ban in audioscrobber (plus use song in tooltips)[2]



[1] http://library.gnome.org/devel/hig-book/stable/toolbars-labels-tooltips.html
[2] to be honest I've just changed the original label, if I'm right those appears only in toolbar.
Comment 1 Luca Ferretti 2008-02-16 13:29:21 UTC 
Created attachment 105380 [details] [review]
The proposed patch
Comment 2 Luca Ferretti 2008-02-16 13:30:04 UTC 
Note that Magnatune and Jamendo plugins should be updated too, but I'm not confident with Python...
Comment 3 Jonathan Matthew 2008-06-12 13:25:53 UTC 
The python plugins are easy enough to do, with a few exceptions.  Python's gettext module is lacking anything like Q_(), and the natural short label for the magnatune "Artist Information" action is "Artist", which obviously appears elsewhere.
Comment 4 Jonathan Matthew 2008-06-15 12:34:00 UTC 
I've committed the patch, but since there is more to do, I'm leaving the bug open.
Comment 5 Jonathan Matthew 2008-07-16 09:37:52 UTC 
*** Bug 541422 has been marked as a duplicate of this bug. ***
Comment 6 Jonathan Matthew 2008-08-17 22:28:36 UTC 
*** Bug 548080 has been marked as a duplicate of this bug. ***
Comment 7 Sindhu S 2013-06-14 17:37:39 UTC 
(In reply to comment #4)
> I've committed the patch, but since there is more to do, I'm leaving the bug
> open.

Can you please specify what other tasks there is left to do? I like to give it a try :)
Comment 8 Jonathan Matthew 2013-06-14 22:23:13 UTC 
This doesn't apply to the way toolbars work now.