After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514574 - Alacarte needs porting to gio
Alacarte needs porting to gio
Status: RESOLVED FIXED
Product: alacarte
Classification: Applications
Component: general
0.11.x
Other Linux
: Low enhancement
: ---
Assigned To: Alacarte Maintainer(s)
Alacarte Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-05 16:58 UTC by Murat Güneş
Modified: 2009-02-04 12:09 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
simple patch (3.11 KB, patch)
2008-07-20 20:30 UTC, Gian Mario Tagliaretti
none Details | Review
patch v2 (3.47 KB, patch)
2008-09-20 19:39 UTC, Cosimo Cecchi
committed Details | Review

Description Murat Güneş 2008-02-05 16:58:19 UTC
Alacarte is listed among the modules that need migrating to gio at http://live.gnome.org/GioPort . The required changes seem trivial; I'll try my hand at a patch if the move is to happen in 2.22 and nobody else is working on it.
Comment 1 Travis Watkins 2008-02-17 06:21:14 UTC
There is currently no python binding for gio but when one does get created I'll be sure to do this.
Comment 2 André Klapper 2008-04-11 13:32:51 UTC
http://svn.gnome.org/viewvc/pygobject/trunk/gio/
<jdahlin> It won't be complete for a while, but I encourage you to start using it right now
<jdahlin> not sure if it's realistic to introduce gvfs/gio compatibility layer in applications
<jdahlin> I need more bug reports, to know what's missing


so please start porting *now* and file reports!
Comment 3 André Klapper 2008-06-22 16:52:31 UTC
Murat, do you have time and interest to work on porting this?


$:andre\> grep -R gnomevfs .
./Alacarte/MainWindow.py: import gtk, gtk.glade, gmenu, gobject, gnomevfs, gnome.ui
./Alacarte/MainWindow.py: file_path = gnomevfs.unescape_string(selection.data, '').strip()
./Alacarte/MainWindow.py: file_info = gnomevfs.get_file_info(
./Alacarte/MainWindow.py: file_path, gnomevfs.FILE_INFO_GET_MIME_TYPE|
./Alacarte/MainWindow.py: gnomevfs.FILE_INFO_FORCE_SLOW_MIME_TYPE|
./Alacarte/MainWindow.py: gnomevfs.FILE_INFO_FOLLOW_LINKS|gnomevfs.FILE_INFO_DEFAULT
./Alacarte/MainWindow.py: handle = gnomevfs.open(file_path)
Comment 4 Murat Güneş 2008-06-22 17:20:21 UTC
Andre, sorry for not reporting earlier; I unfortunately can't safely undertake this at present due to life taking over. You or others can go ahead with it.
Comment 5 André Klapper 2008-06-29 10:48:41 UTC
Murat: Sure, no problem.


Anybody: We now have GIO bindings in PyGObject SVN, see bug 537551.
Comment 6 André Klapper 2008-07-15 14:20:04 UTC
And we now have a pygobject 2.15 release including these bindings.
no reason to not work on this. :-)
Comment 7 Gian Mario Tagliaretti 2008-07-20 20:30:05 UTC
Created attachment 114876 [details] [review]
simple patch
Comment 8 Cosimo Cecchi 2008-07-21 09:40:14 UTC
Comment on attachment 114876 [details] [review]
simple patch

>+			file_info = myfile.query_info("*")

I am not an Alacarte maintainer, but this looks a bit overkill; you don't need to query for all the available info on the file just to get the content type. You can use query_info("standard::content_type") I guess, if the syntax is the same as in C.
Anyway, it would be good to have this in before 2.24!
Comment 9 André Klapper 2008-08-10 22:25:03 UTC
amaranth: ping - can we please get this in soon?
Comment 10 André Klapper 2008-08-17 05:01:12 UTC
amaranth: ping - can we please get this in soon?
Comment 11 André Klapper 2008-09-02 10:47:27 UTC
amaranth: ping - you're dead?
Comment 12 Vincent Untz 2008-09-02 13:30:09 UTC
-			file_path = gnomevfs.unescape_string(selection.data, '').strip()
+			file_path = selection.data.decode('string_escape').strip()

Sounds wrong to me. It doesn't do the same thing, AFAIK.
Comment 13 Cosimo Cecchi 2008-09-02 17:35:34 UTC
Isn't there a python-binded function for g_uri_unescape_string for that?
Comment 14 Vincent Untz 2008-09-03 11:52:35 UTC
(In reply to comment #13)
> Isn't there a python-binded function for g_uri_unescape_string for that?

Possibly. I didn't check -- I only gave a quick look at the patch ;-)
Comment 15 André Klapper 2008-09-11 13:14:28 UTC
Cosimo: Interested in updating the patch? :-)
Comment 16 Cosimo Cecchi 2008-09-20 19:39:13 UTC
Created attachment 119050 [details] [review]
patch v2

Updated patch, fixes the comments above and clean up a bit the configure script.
Vincent, Andre: do you think it's worth to push this into the (imminent :/) 2.24.0 release? I can ask r-t a freeze break for it if you think it's worth.
Comment 17 Vincent Untz 2008-09-21 00:05:05 UTC
Cosimo: no way it can go in 2.24.0 at this point. It's not important enough.
Comment 18 André Klapper 2009-01-19 14:59:55 UTC
I propose to get this in and have a non-maintainer release.
Seems like this module is dead.
Comment 19 Cosimo Cecchi 2009-01-19 16:04:10 UTC
This has been fixed in trunk, will be there in 0.11.7, which I just released. Closing as FIXED.
Comment 20 André Klapper 2009-01-19 17:12:07 UTC
Cosimo:  :-*
Comment 21 Andreas Proschofsky 2009-02-04 11:57:48 UTC
A quick followup on this: Shouldn't the call to gnome.ui.authentication_manager_init() in MainWindow.py be removed too? At least according to http://live.gnome.org/LibgnomeMustDie this is only needed for gnome-vfs.
Comment 22 Cosimo Cecchi 2009-02-04 12:09:12 UTC
You're right, I fixed this in trunk.

2009-02-04  Cosimo Cecchi  <cosimoc@gnome.org>

	* Alacarte/MainWindow.py: removed a call to
	gnome.ui.authentication_manager_init(), as that's not needed
	with GIO anymore. Thanks to Andreas Proschofsky.