After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514380 - Drop gnome-vfs dependency
Drop gnome-vfs dependency
Product: empathy
Classification: Core
Component: General
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Reported: 2008-02-04 18:53 UTC by Cosimo Cecchi
Modified: 2008-03-11 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

gio-migration (6.08 KB, patch)
2008-02-04 19:01 UTC, Cosimo Cecchi
reviewed Details | Review

Description Cosimo Cecchi 2008-02-04 18:53:07 UTC
Gnome-vfs is getting deprecated and the whole GNOME is moving to the new gio API introduced in GLib 2.15. See
Patch following.
Comment 1 Cosimo Cecchi 2008-02-04 19:01:32 UTC
Created attachment 104420 [details] [review]

Drop gnome-vfs dependency.
One comment: in the actual code we use gnome_vfs_url_show () to open the default application for clicked URLs; that is not multihead compatible, as it opens the application on the default screen, not the one Empathy's widget is in. We'll be able to fix multihead for that when we can depend on GTK+ trunk (for 2.24), using GdkAppLaunchContext, unless we want to c-p EelAppLaunchContext for that, as we did in Epiphany. I added a FIXME comment to the patch explaining this.
Comment 2 Xavier Claessens 2008-02-06 12:45:45 UTC
Seems good. Last time I tried to replace gnome_vfs_open_url() there was some unimplemented functions in GIO. The problem was gio needed a way to look in gconf for uri handlers with GNOME desktop. Is that fixed now?
Comment 3 Xavier Claessens 2008-02-07 12:57:34 UTC
Seems that issue is solved in bug #509615. However 2.15.5 doesn't seems to be released yet and it doesn't compile with 2.15.4, so I'm waiting for the next release to get into ubuntu hardy like that I can test the patch.

I pushed the code in the gio branch of my git repository and added 2 little patches:;a=shortlog;h=gio
Comment 4 Cosimo Cecchi 2008-02-14 00:23:06 UTC
GLib 2.15.5 has been out for a few days and should be in hardy now.
Comment 5 Xavier Claessens 2008-02-15 15:15:17 UTC
I think lots of users won't use empathy HEAD anymore if I commit this patch and empathy really needs testing...

I keep this patch in my gio branch[1] and will commit once major distro has glib 2.16.0 or if we have real useful thing using gio (like the ft branch).


Comment 6 Xavier Claessens 2008-03-11 09:33:56 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.