After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513778 - Migrate to gio
Migrate to gio
Product: librsvg
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Reported: 2008-02-01 21:22 UTC by Jan Arne Petersen
Modified: 2008-02-02 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add gio support. Drop gnome-vfs support. (6.03 KB, patch)
2008-02-01 21:24 UTC, Jan Arne Petersen
needs-work Details | Review
Make gio optional (6.81 KB, patch)
2008-02-01 21:59 UTC, Jan Arne Petersen
none Details | Review
Fix missing config.h include (6.94 KB, patch)
2008-02-01 22:05 UTC, Jan Arne Petersen
none Details | Review
Fix bug (6.81 KB, patch)
2008-02-01 22:48 UTC, Jan Arne Petersen
committed Details | Review

Description Jan Arne Petersen 2008-02-01 21:22:40 UTC
Use gio instead of gnome-vfs.
Comment 1 Jan Arne Petersen 2008-02-01 21:24:19 UTC
Created attachment 104222 [details] [review]
Add gio support. Drop gnome-vfs support.
Comment 2 Dominic Lachowicz 2008-02-01 21:29:12 UTC
Nice patch. Thanks.

I'd prefer that VFS support were optional, so that you didn't need a bleeding-edge version of glib to compile & run the program.

It can be as simple as a compile-time check:

Comment 3 Christian Persch 2008-02-01 21:56:00 UTC
Would it be possible to also have some public gio supporting functions, i.e. 
rsvg_handle_new_from_gfile and rsvg_handle_new_from_gfile_async ?
Comment 4 Dominic Lachowicz 2008-02-01 21:56:59 UTC
Sure, if someone has a concrete need for them.
Comment 5 Jan Arne Petersen 2008-02-01 21:59:47 UTC
Created attachment 104224 [details] [review]
Make gio optional
Comment 6 Jan Arne Petersen 2008-02-01 22:05:31 UTC
Created attachment 104225 [details] [review]
Fix missing config.h include
Comment 7 Jan Arne Petersen 2008-02-01 22:48:07 UTC
Created attachment 104228 [details] [review]
Fix bug
Comment 8 Dominic Lachowicz 2008-02-02 16:43:13 UTC
Comment 9 Olav Vitters 2008-02-02 17:58:49 UTC
Wheeh!! Thanks for the patch! There is a small issue with this (the pkg-config file):

$ cat librsvg-2.0.pc


Name: librsvg
Description: library that renders svg files
Version: 2.21.0
Requires: glib-2.0 gdk-pixbuf-2.0
Requires.private: @LIBGNOME_VFS_PKG@
Libs: -L${libdir} -lrsvg-2
Cflags: -I${includedir}/librsvg-2

Note the @GNOME_VFS_SUPPORTED@ and @LIBGNOME_VFS_PKG@. Please fix the file as well (I have no idea how).
Comment 10 Dominic Lachowicz 2008-02-02 19:20:19 UTC