After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513246 - installs data files under $(libdir)
installs data files under $(libdir)
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-01-30 20:00 UTC by Christian Persch
Modified: 2008-02-01 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (27.48 KB, patch)
2008-01-30 20:01 UTC, Christian Persch 		reviewed Details | Review

Description Christian Persch 2008-01-30 20:00:51 UTC 
g-s-d puts various plugin data files under $(libdir), e.g. acme.glade.

Also I noticed that the plugins directory was scanned recursively, while most subdirs just contained the .gnome-settings-plugin and the .so/.la files. I therefore propose:
- to make the plugins directory flat, containing the .so's and the .gnome-settings-plugin files. That will decrease startup time a bit (haven't measured how much).
- to install data files under $(pkgdatadir)
Comment 1 Christian Persch 2008-01-30 20:01:39 UTC 
Created attachment 104060 [details] [review]
proposed patch
Comment 2 Jens Granseuer 2008-02-01 17:25:59 UTC 
Sounds good to me. However, this patch clashes with changes currently being made in bug 504203, so it would be nice to either

a) commit this very quickly
b) wait until 504203 is resolved and adapt, or
c) modify this patch to include the fix for 504203
Comment 3 Christian Persch 2008-02-01 18:27:29 UTC 
        Bug #513246.

        * acinclude.m4:
        * configure.ac:
        * plugins/a11y-keyboard/Makefile.am:
        * plugins/background/Makefile.am:
        * plugins/clipboard/Makefile.am:
        * plugins/default-editor/Makefile.am:
        * plugins/dummy/Makefile.am:
        * plugins/font/Makefile.am:
        * plugins/keybindings/Makefile.am:
        * plugins/keyboard/Makefile.am:
        * plugins/media-keys/Makefile.am:
        * plugins/media-keys/actions/Makefile.am:
        * plugins/mouse/Makefile.am:
        * plugins/screensaver/Makefile.am:
        * plugins/sound/Makefile.am:
        * plugins/typing-break/Makefile.am:
        * plugins/xrandr/Makefile.am:
        * plugins/xrdb/Makefile.am:
        * plugins/xsettings/Makefile.am: Use a flat directory instead of a
        directory hierarchy to install the plugins into.
        Install data files under $(pkgdatadir), not under $(libdir).

        * src/Makefile.am:
        * src/gnome-settings-plugins-engine.c:
        (gnome_settings_plugin_info_free),
        (gnome_settings_plugins_engine_load),
        (gnome_settings_plugins_engine_load_file),
        (gnome_settings_plugins_engine_load_dir): Don't scan the plugins
        directory recursively. Use GSlice for the plugin info struct.

I'll post an updated patch in bug 504203.