After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512492 - Can't drag multiple themes at once into the preferences dialog
Can't drag multiple themes at once into the preferences dialog
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
CVS HEAD
Other All
: Normal minor
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 512483 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-28 05:24 UTC by John Millikin
Modified: 2008-01-31 03:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Allow multiple files to be dropped, using GIO (44.83 KB, patch)
2008-01-28 05:54 UTC, John Millikin
committed Details | Review
Only show the dialog if copying takes more than half a second (2.38 KB, patch)
2008-01-29 04:30 UTC, John Millikin
committed Details | Review

Description John Millikin 2008-01-28 05:24:30 UTC
I would expect that selecting multiple screensaver themes and dragging them into the dialog would add them all, but only the first is added.

Other information:
Comment 1 John Millikin 2008-01-28 05:54:45 UTC
Created attachment 103858 [details] [review]
Allow multiple files to be dropped, using GIO

The existing file transfer dialog was strongly oriented around copying one file at a time. Rather than launching a dozen dialogs per drop, or trying to re-architect the existing transfer dialog, I created a new one. As it happens the transfer dialog was also where almost all the GnomeVFS code was located, so I wrote the replacement in GIO to satisfy http://live.gnome.org/GioPort .
Comment 2 William Jon McCann 2008-01-29 03:05:54 UTC
Cool.  Thanks for doing this.  I've only tested it lightly and it seems to work.  However, it flashes onto the screen so fast I can't really see it.  I wonder if we should only display the dialog if the transfer takes more than half a second or so.  What do you think?

Committed to trunk to get it in before freezes.
Comment 3 William Jon McCann 2008-01-29 03:09:56 UTC
*** Bug 512483 has been marked as a duplicate of this bug. ***
Comment 4 John Millikin 2008-01-29 04:30:37 UTC
Created attachment 103929 [details] [review]
Only show the dialog if copying takes more than half a second

> However, it flashes onto the screen so fast I can't really see it.  I
> wonder if we should only display the dialog if the transfer takes more than
> half a second or so.  What do you think?

I think it'd be very nice, patch attached.
Comment 5 William Jon McCann 2008-01-31 03:11:22 UTC
Committed.  Thanks again.