GNOME Bugzilla – Bug 511826
Window decoration don't update color on GTK+ theme change
Last modified: 2008-05-26 20:05:23 UTC
Metacity don't update the color of the window decoration when you change your current gtk+ theme (non the whole GNOME theme, only the control option). Steps (let's assume you are using Clearlooks, default GNOME theme): 1. Open Appearence capplet (gnome-appearance-properties) 2. Click "Customize" button 3. Select Raleigh in Controls list 4. The newly select theme is applied to GTK+ applications Expected Results: The window titlebar should use the color from the new theme, i.e. the same green used for selected item in list Current Results: The window titlebar keeps the color from previous Clearlooks theme Additional Info: This bug seems to happen after the extraction of gnome-settings-daemon from gnome-control-center.
Wait a moment, one more test: I saved the new theme created with previous steps (i.e. Raleigh for GTK+, Clearlooks for Metacity, lets call it Raleilooks), then I used the main Appearance capplet to select Clearlooks (meta)theme. The window title color is not updated selecting the Raleilooks theme from main dialog too. Same if you save a new theme changing colors in customiza sub dialog.
Reassigning to gnome-themes, only Clearlooks* metacity themes have this issue.
It is very unlikely that this is a theme bug. My first guess would be that either metacity or GTK+ is at fault. It kind of looks to me like metacity is doing some caching, and that breaks things. I am getting a case where a fullscreen window picks up the change, but the buttons on that window do not. Reassigning back to metacity. After a quick look at the changelog I guess it may be caused by the performance work from bug #377495.
gnome 2.22.0 is affected
cc'ing me because it have the bug with Clearlook / Gilouche
Another test case: Go to customize and change the selected items color, the Metacity theme doesn't update. I found two work arounds: 1. In customize menu change window border to something else and back again. 2. Restart Appearance Properties
I think this bug occurred between revisions 3453 and 3454 of the iains-blingtastic-bucket-o-bling branch of metacity which was merged to trunk in version 3483 of metacity. The commit message for this change says it provides theme speedup changes.
Created attachment 110814 [details] [review] Patch to fix bug 511826 I've made a patch that fixes this issue for me. Using metacity-theme-viewer benchmarks I was not able to see a noticeable performance hit from removing what appeared to be a mechanism for reducing the number of times meta_color_spec_render was run.
Tested; works fine. Thank you! http://svn.gnome.org/viewvc/metacity?rev=3708&view=rev
Er, and that means the bug is closed. *slaps self*