After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511700 - port to gio
port to gio
Product: gnome-terminal
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Reported: 2008-01-24 02:59 UTC by André Klapper
Modified: 2008-02-11 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (3.50 KB, patch)
2008-01-24 03:01 UTC, André Klapper
needs-work Details | Review
patch (3.53 KB, patch)
2008-01-30 01:49 UTC, André Klapper
none Details | Review

Description André Klapper 2008-01-24 02:59:33 UTC
port gnome-terminal from gnome-vfs to gio
Comment 1 André Klapper 2008-01-24 03:01:13 UTC
Created attachment 103603 [details] [review]

i'm confused that listed GLIB twice:
i have removed the latter one.

  #include <libgnomevfs/gnome-vfs-utils.h>
in /src/terminal-screen.c was obsolete and just forgotten there.

please review this carefully, i'm a total idiot with regard to code patches, but was in the mood to try something new. thanks :)
Comment 2 Christian Persch 2008-01-24 12:03:49 UTC
+      if (file_info != NULL) {
+        mime_type = g_file_info_get_content_type (file_info);
+	g_object_unref (file_info);

mime_type now points to freed memory.

+      file_info = g_file_query_info (file1, 

We only support local files here for now, so querying sync should be ok. Should file a bug to move to _real_ gio though, i.e. supporting remote files here :)
Comment 3 André Klapper 2008-01-30 01:49:38 UTC
Created attachment 104000 [details] [review]

let's see if i have more luck this time. if not, feel free to fix anything and commit if you have time...
Comment 4 Christian Persch 2008-01-31 12:53:39 UTC
Looks ok to me now :)
Comment 5 Christian Persch 2008-02-11 22:02:38 UTC