GNOME Bugzilla – Bug 509756
Migrate from GnomeVFS to GIO / GVFS
Last modified: 2015-03-24 13:01:09 UTC
In the next future gnome-panel should totally dump GnomeVFS and use new GIO API. Meanwhile, i.e. in 2.21/2.22 timeframe, the panel should use GIO/GVFS at least to populate the Places menu. In fact currently (2.21.x) in GNOME Desktop we have Nautilus using the new vfs to show and manage mounted volumes and drives and the panel using GnomeVFS. Panel should list the same mounted stuff under Places and should remove refereces to connected servers (the list and the menu entry under places, and the applet).
We should at least make sure Places and Bookmarks are consistent
Created attachment 104369 [details] [review] 20080204_bgo_509756_gioport-clock.diff A quick patch for the clock applet. Nothing broke here so I guess I was successful :)
Created attachment 104370 [details] [review] 20080204_bgo_509756_gioport_gnome-panel_menu.c.diff Patch for gnome-panel/menu.c, nothing broke, copying launchers work here. Note that by some reason I don't have almost any items on my menus, but this seems to be due to gnome-panel being run in an almost empty jhbuild.
Created attachment 104371 [details] [review] 20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff This is a patch for gnome-panel/panel-menu-items.c. It's somewhat dirty, I'm not sure about the volumes part, I'm not sure if I should use GUnixMount stuff or just a GMount. There's lot of stuff commented as you might see, so please consider this just a base, aka, please tell me how to fix it or fix it :).
uhm, regarding last patch, some testing showed me that bookmarks are broken, that's because: + url = g_file_get_uri (g_file_new_for_path (path)); path is actually a file:/// string always, so it should (always) work with: + url = path; Works fine with this "fix" but I don't know if I'm being naive here.
Also I just realized that G* stuff should be freed with g_object_unref(). Uhmmm... duh! :)
Created attachment 104409 [details] [review] 20080204_bgo_509756_gioport_gnome-panel_menu.c.diff Adds unrefs for gfiles.
Created attachment 104410 [details] [review] 20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff Add unrefs for gfiles and fixes some issues.
Created attachment 104413 [details] [review] bgo_509756_gioport_gnome-panel_clock-location.c.diff Updated fixing a leaked g_file
Created attachment 104414 [details] [review] 20080204_bgo_509756_gioport_gnome-panel_panel-util.c.diff
*** Bug 514382 has been marked as a duplicate of this bug. ***
Committed the clock patch, with some changes.
I'm reworking the panel-util.c patch. Diego, there are a few leaks, some non-sense code and some things that were not ported. Was I supposed to commit without looking at it? ;-)
Committed menu.c patch after some changes...
Well, I didn't say the patches would be good... :P.
Current status: + bug in panel_util_get_label_for_uri(): we can't get the hostname + panel-menu-items.c is not ported yet (I've a patch based on Diego's one) + we still use gnome_vfs_unescape_string_for_display() in panel.c
I've committed my panel-menu-items patch. Keeping the bug open for the following issues: + bug in panel_util_get_label_for_uri(): we can't get the hostname + we still use gnome_vfs_unescape_string_for_display() in panel.c + there's no submenu anymore for the removable media
No more a showstopper.
Everything is done now.
What is this? Bug 529243 http://live.gnome.org/GioPort says that gnome-panel has been fully ported