After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509756 - Migrate from GnomeVFS to GIO / GVFS
Migrate from GnomeVFS to GIO / GVFS
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 514382 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-15 21:43 UTC by Luca Ferretti
Modified: 2015-03-24 13:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
20080204_bgo_509756_gioport-clock.diff (1.88 KB, patch)
2008-02-04 10:33 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
20080204_bgo_509756_gioport_gnome-panel_menu.c.diff (2.55 KB, patch)
2008-02-04 10:38 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff (9.51 KB, patch)
2008-02-04 10:41 UTC, Diego Escalante Urrelo (not reading bugmail)
needs-work Details | Review
20080204_bgo_509756_gioport_gnome-panel_menu.c.diff (2.70 KB, patch)
2008-02-04 17:13 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review
20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff (10.81 KB, patch)
2008-02-04 17:15 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review
bgo_509756_gioport_gnome-panel_clock-location.c.diff (2.02 KB, patch)
2008-02-04 17:20 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review
20080204_bgo_509756_gioport_gnome-panel_panel-util.c.diff (7.00 KB, patch)
2008-02-04 17:26 UTC, Diego Escalante Urrelo (not reading bugmail)
needs-work Details | Review

Description Luca Ferretti 2008-01-15 21:43:33 UTC
In the next future gnome-panel should totally dump GnomeVFS and use new GIO API.

Meanwhile, i.e. in 2.21/2.22 timeframe, the panel should use GIO/GVFS at least to populate the Places menu.

In fact currently (2.21.x) in GNOME Desktop we have Nautilus using the new vfs to show and manage mounted volumes and drives and the panel using GnomeVFS. Panel should list the same mounted stuff under Places and should remove refereces to connected servers (the list and the menu entry under places, and the applet).
Comment 1 Christian Kirbach 2008-01-16 11:08:20 UTC
We should at least make sure Places and Bookmarks are consistent
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 10:33:18 UTC
Created attachment 104369 [details] [review]
20080204_bgo_509756_gioport-clock.diff

A quick patch for the clock applet. Nothing broke here so I guess I was successful :)
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 10:38:24 UTC
Created attachment 104370 [details] [review]
20080204_bgo_509756_gioport_gnome-panel_menu.c.diff

Patch for gnome-panel/menu.c, nothing broke, copying launchers work here.
Note that by some reason I don't have almost any items on my menus, but this seems to be due to gnome-panel being run in an almost empty jhbuild.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 10:41:14 UTC
Created attachment 104371 [details] [review]
20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff

This is a patch for gnome-panel/panel-menu-items.c. It's somewhat dirty, I'm not sure about the volumes part, I'm not sure if I should use GUnixMount stuff or just a GMount. There's lot of stuff commented as you might see, so please consider this just a base, aka, please tell me how to fix it or fix it :).
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 11:20:36 UTC
uhm, regarding last patch, some testing showed me that bookmarks are broken, that's because:

+	url = g_file_get_uri (g_file_new_for_path (path));

path is actually a file:/// string always, so it should (always) work with:

+	url = path;

Works fine with this "fix" but I don't know if I'm being naive here.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 11:44:40 UTC
Also I just realized that G* stuff should be freed with g_object_unref(). Uhmmm... duh! :)
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 17:13:23 UTC
Created attachment 104409 [details] [review]
20080204_bgo_509756_gioport_gnome-panel_menu.c.diff

Adds unrefs for gfiles.
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 17:15:16 UTC
Created attachment 104410 [details] [review]
20080204_bgo_509756_gioport_gnome-panel_panel-menu-items.c.diff

Add unrefs for gfiles and fixes some issues.
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 17:20:44 UTC
Created attachment 104413 [details] [review]
bgo_509756_gioport_gnome-panel_clock-location.c.diff

Updated fixing a leaked g_file
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2008-02-04 17:26:15 UTC
Created attachment 104414 [details] [review]
20080204_bgo_509756_gioport_gnome-panel_panel-util.c.diff
Comment 11 Cosimo Cecchi 2008-02-04 20:22:51 UTC
*** Bug 514382 has been marked as a duplicate of this bug. ***
Comment 12 Vincent Untz 2008-02-09 13:47:17 UTC
Committed the clock patch, with some changes.
Comment 13 Vincent Untz 2008-02-09 15:07:58 UTC
I'm reworking the panel-util.c patch. Diego, there are a few leaks, some non-sense code and some things that were not ported. Was I supposed to commit without looking at it? ;-)
Comment 14 Vincent Untz 2008-02-09 15:47:01 UTC
Committed menu.c patch after some changes...
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2008-02-09 20:07:07 UTC
Well, I didn't say the patches would be good... :P.
Comment 16 Vincent Untz 2008-02-10 20:03:03 UTC
Current status:
 + bug in panel_util_get_label_for_uri(): we can't get the hostname
 + panel-menu-items.c is not ported yet (I've a patch based on Diego's one)
 + we still use gnome_vfs_unescape_string_for_display() in panel.c
Comment 17 Vincent Untz 2008-02-10 22:15:06 UTC
I've committed my panel-menu-items patch.

Keeping the bug open for the following issues:
 + bug in panel_util_get_label_for_uri(): we can't get the hostname
 + we still use gnome_vfs_unescape_string_for_display() in panel.c
 + there's no submenu anymore for the removable media
Comment 18 Vincent Untz 2008-02-11 09:29:25 UTC
No more a showstopper.
Comment 19 Vincent Untz 2008-02-11 11:52:34 UTC
Everything is done now.
Comment 20 Pavel Šefránek 2008-04-25 21:13:10 UTC
What is this? Bug 529243 

http://live.gnome.org/GioPort says that gnome-panel has been fully ported