GNOME Bugzilla – Bug 506422
Icon directory cannot be set by environment variable
Last modified: 2018-03-26 15:04:23 UTC
In spite of catalog and module directories the icon directory can not be set by environment variable, so in case of a custom widget the related icon must be given in the package's installed pixmap directory. The following patch may solve the problem: --- gladeui/glade-app.c (revision 1666) +++ gladeui/glade-app.c (working copy) @@ -425,9 +425,17 @@ if (!initialized) { + const gchar *search_path; + gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (), pixmaps_dir); + if ((search_path = g_getenv (GLADE_ENV_ICON_PATH)) != NULL) + { + gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (), + search_path); + } + glade_cursor_init (); initialized = TRUE; Index: gladeui/glade-app.h =================================================================== --- gladeui/glade-app.h (revision 1666) +++ gladeui/glade-app.h (working copy) @@ -40,6 +40,7 @@ #define GLADE_ENV_CATALOG_PATH "GLADE_CATALOG_PATH" #define GLADE_ENV_MODULE_PATH "GLADE_MODULE_PATH" +#define GLADE_ENV_ICON_PATH "GLADE_ICON_PATH" typedef struct _GladeApp GladeApp; typedef struct _GladeAppPrivate GladeAppPrivate;
Created attachment 133441 [details] [review] Patch
Dear glade3 maintainters, Would you be so kind and _TAKE A LOOK AT THIS PATCH_ and if it's fulfilling your needs, would you also be so kind and _APPLY IT_? THANK YOU!
(In reply to comment #2) > Dear glade3 maintainters, > > Would you be so kind and _TAKE A LOOK AT THIS PATCH_ and if it's fulfilling > your needs, would you also be so kind and _APPLY IT_? > > THANK YOU! > There is no need for capitalizing here. Yes the patch looks pretty fine, although it could use an update to the docs. Yes it would be great if there were a real plurality to that "Dear glade3 maintainers,"; it has a ring to it ;-) And yes, I gladly appreciate you volunteering to step up to that role and actually help us sort through/fix/apply all of the more minor bugs that there are to deal with in Glade. It might be better if you started by gathering a list of the more important easy to resolve bugs and posting it to the glade-devel mailing list and we could start with that. Thank you.
(In reply to comment #3) > There is no need for capitalizing here. Still, it seems the only way to get attention for a bug is capitalizing. (Needless to say: It works!) > Yes it would be great if there were a real plurality > to that "Dear glade3 maintainers,"; it has a ring to it ;-) > I don't know whether you're the only maintainer or not but the bug is assigned to: Glade 3 Maintainers <glade3-maint@gnome.bugs> Maybe you should discuss this with gnome's bugzilla maintainers. > And yes, I gladly appreciate you volunteering to step up > to that role and actually help us sort through/fix/apply all > of the more minor bugs that there are to deal with in Glade. > If you were writing this to me -> I did not fix anything in here. > It might be better if you started by gathering a list of the > more important easy to resolve bugs and posting it to the > glade-devel mailing list and we could start with that. > This bug can be really important to anyone who want to use custom widgets with custom icons in glade. > Thank you. You're welcome.
(In reply to comment #4) > (In reply to comment #3) > > There is no need for capitalizing here. > Still, it seems the only way to get attention for a bug is capitalizing. > (Needless to say: It works!) > Not impressed with your attitude buster. People who come around and try to bring attention to their one bug I get a dime a dozen, you want to do something constructive, then help out and gather a list and see what we can do about blockers for the next release. What you are doing here is asking me to jump up and scratch your itch, actually with caps on you are YELLING it at me. So just jump on board or move aside and give me a break.
(In reply to comment #5) > Not impressed with your attitude buster. > Buster? And what's wrong with yours? > What you are doing here is asking me to jump up and > scratch your itch, actually with caps on you are YELLING it > at me. Yeah... clearly glade3 needs another maintainer if you think that this is only my itch.
Created attachment 139618 [details] [review] documentation In replying to comment 3 here is the documentation patch. It may help your work, if it is good enough.
Is there any update on this bug? I see there is a patch, it is documented, it has been discussed. I have the same issue, I'm surprised it's been put on hold for 6 years.
For what it matters, I've tested the patch on Gentoo with the latest stable glade and it works for me. I don't know if that exact patch still applies, I've just copy/pasted the new lines at the right spot (grep for "if (!initialized"). One improvement would be to support colon-separated paths in the environment variable, but this patch already fixes my problem and I don't need multiple paths. Please merge it into the main code.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/24.