Created attachment 139599 [details] [review]
Put DAAP sharing prefs in 'Music' prefs tab

Changes made from within the new 'Music' tab will appear in both the new Sharing section, and the old DAAP plugin 'Configure' dialog.
If changes are made from the 'Configure' dialog (or through manually through gconf-editor), then those changes don't seem to appear in the new 'Sharing' section.

Any ideas there?

Also, see the comment just above the 'rb_daap_sharing_default_share_name' function.

Adding to CC list.

(In reply to comment #1)
> Created an attachment (id=139599) [edit]
> Put DAAP sharing prefs in 'Music' prefs tab
> 
> Changes made from within the new 'Music' tab will appear in both the new
> Sharing section, and the old DAAP plugin 'Configure' dialog.
> If changes are made from the 'Configure' dialog (or through manually through
> gconf-editor), then those changes don't seem to appear in the new 'Sharing'
> section.
> 
> Any ideas there?

You never listen to the gconf key changing.

> Also, see the comment just above the 'rb_daap_sharing_default_share_name'
> function.

Either it's only used within the file, and you need to declare it static, or you need to declare it in the header for that source file.

(In reply to comment #2)
> Adding to CC list.

You don't need to add comments to add yourself to the CC:

Created attachment 139766 [details] [review]
Version 2: Listen for gconf notifications, declare function as static

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/483.