GNOME Bugzilla – Bug 493783
Regression: Message viewer jumps to the top when asking an attachment to be displayed inline
Last modified: 2008-07-02 12:46:44 UTC
The problem is that if a message has attachments that can be displayed inline (such as images or text files), then the message viewer shows them at the bottom of the email with a right pointing arrow button that allows the user to "open" the attachment inside the viewer - like a collapsible folder. Previously in version 2.10 when a user clicked on the arrow button to open the attachment, it would just swing open. Starting with version 2.20 when clicking the arrow attachment button the message viewer shows a blank screen with the message "formatting message" and then redisplays the message with the attachment viewer at the top, while previously it was at the bottom. This behavior makes it very annoying to open attachments inline, as for each attachment I have to scroll down to the bottom, push the button, then scroll down again. lather, rinse, repeat if you have more then one attachment. I also noticed a similar behavior whit emails that contain a lot of embedded images (which I tend to receive several times a day) - its impossible to view the message before the evolution message viewer had time to load all the attachments because each time I try to scroll down the message viewer jumps to the top again. This also wasn't happening in version 2.10. I marked this bug as "major" although there is no obvious loss of functionality, as this is a regression from a previous version which causes the evolution to be very annoying for people who receive emails with embedded images or image attachments.
Created attachment 99327 [details] [review] proposed evo patch for evolution; I'm sorry I caused this and didn't notice before, so this will fix the issue. Thanks for reporting it.
Milan, commit this. I think it mostly works, but if I press hide/expand faster or repeatedly it still fails. (Commit to head/stable)
Committed to trunk. Committed revision 34554. Committed to stable. Committed revision 34555. I think it fails because of other synchronization issues, because based on the code, it will not preserve scroll positions as well (I copied same condition from there).
Is this supposed to be fixed now ? I'm currently using evo 2.22.1 in latest Ubuntu and it still behaves that way. I think that it might have been fixed for a short while and then reverted back to the problematic behavior.
Sure, this is supposed to work. I tried with 2.22.2 and 2.23.3 and both works fine (I have a text mail with 3 "clickable" attachments, text file, tif and jpg). To be honest, I noticed some strange behavior before too, but it seems like fixed again. The patch here is there (in your version) for sure, but why it doesn't work for you is a question...
Hi Oded, did you try with that 2.22.2+ version?
Ahh, I see now. The bug #494457 contains a test mbox, where I can reproduce it (it doesn't work for HTML messages only, when I force the plain text, then it works fine).
*** Bug 494457 has been marked as a duplicate of this bug. ***
Created attachment 113388 [details] [review] proposed gtkhtml patch for gtkhtml; With this patch it keeps the scroll almost where it was. Actually it jump a few pixels below, probably some conversion error between float and int, or some bog somewhere else. The cause of the trouble was with an iframe, in which the HTML part is rendered. Because it's treated as a subitem, then there was more repaints, first with small body, second with bigger body. It was very nice to find out what's going on. I'm not sure whether this will introduce other inconsistencies. Hopefully not, but anyway...
also see bug 391786
It works fine for me. Go ahead.
Committed to trunk. Committed revision 8883. Committed to gnome-2-22. Committed revision 8884.