After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 483620 - All Rtp buffers are discarded -- gst_rtp_buffer_get_payload_subbuffer always return null
All Rtp buffers are discarded -- gst_rtp_buffer_get_payload_subbuffer always...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal critical
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-05 07:35 UTC by Laurent Glayal
Modified: 2007-10-05 07:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Laurent Glayal 2007-10-05 07:35:31 UTC 
Erroneous replacement,
http://webcvs.freedesktop.org/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstrtpbuffer.c?r1=1.17&r2=1.18
Test should be G_UNLIKELY(offset > plen)
Comment 1 Sebastian Dröge (slomo) 2007-10-05 07:40:15 UTC 
Well, shouldn't it be offset >= plen, i.e. !(offset < plen)?
Comment 2 Laurent Glayal 2007-10-05 07:42:45 UTC 
Probably.
Comment 3 Sebastian Dröge (slomo) 2007-10-05 07:48:51 UTC 
2007-10-05  Sebastian Dröge  <slomo@circular-chaos.org>

        * gst-libs/gst/rtp/gstrtpbuffer.c:
        (gst_rtp_buffer_get_payload_subbuffer):
        Fix bug introduced with last commit which inverted the logic and
        caused all buffers to be dropped. Fixes #483620.
        Thanks to Laurent Glayal <spglegle at yahoo dot fr> for noticing.