After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 482548 - Make upnp plugin (media store) work again
Make upnp plugin (media store) work again
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 469852
Blocks:
 
 
Reported: 2007-10-02 12:15 UTC by Bastien Nocera
Modified: 2007-10-10 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rb-coherence-fixes.patch (3.80 KB, patch)
2007-10-02 12:15 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2007-10-02 12:15:12 UTC
Big patch attached, with a lot of help from Frank Scholz <coherence@beebits.net>

- Couple of changes I don't really understand by Frank in the Container __init__
- Give out the "bitrate" in bytes/sec as the spec says it "could" be (fixes extremely low bitrates showing up with the PS3 UI)
- Give out the duration in HH:MM:SS as per the spec (fixes the tracks showing up as X hours long instead of X seconds long)
- Correctly escape filepaths so the web server knows where to find them
- Force GStreamer application/x-id3 mime-type to audio/mpeg
- Start the coherence server after the twisted reactor, otherwise coherence doesn't get hooked up and nothing works
- Shutdown coherence so it disappears from the local network
Comment 1 Bastien Nocera 2007-10-02 12:15:39 UTC
Created attachment 96510 [details] [review]
rb-coherence-fixes.patch
Comment 2 gareth foster 2007-10-06 00:23:00 UTC
Yay!
Comment 3 Alex Lancaster 2007-10-09 10:28:08 UTC
Patch appears to work for me when testing with uShare exported UPnP source.
Comment 4 Bastien Nocera 2007-10-10 13:34:29 UTC
2007-10-10  Bastien Nocera  <hadess@hadess.net>

        * plugins/coherence/upnp_coherence/MediaStore.py:
        * plugins/coherence/upnp_coherence/__init__.py:
        - Couple of changes I don't really understand by Frank in the
        Container __init__
        - Give out the "bitrate" in bytes/sec as the spec says it "could" be
        (fixes extremely low bitrates showing up with the PS3 UI)
        - Give out the duration in HH:MM:SS as per the spec (fixes the tracks
        showing up as X hours long instead of X seconds long)
        - Correctly escape filepaths so the web server knows where to find them
        - Force GStreamer application/x-id3 mime-type to audio/mpeg
        - Start the coherence server after the twisted reactor, otherwise
        coherence doesn't get hooked up and nothing works
        - Shutdown coherence so it disappears from the local network

        With help from Frank Scholz <coherence@beebits.net>
        (Closes: #482548)