After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 470479 - configure failure with gtksourceview-2.x
configure failure with gtksourceview-2.x
Product: drivel
Classification: Deprecated
Component: general
Other Linux
: Normal normal
: 3.0
Assigned To: Neil Williams
Todd Kulesza
: 341739 438785 475089 585283 (view as bug list)
Depends on:
Reported: 2007-08-26 17:37 UTC by Ed Catmur
Modified: 2009-08-20 06:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

gtksourceview-2.patch (3.94 KB, patch)
2007-08-26 18:03 UTC, Ed Catmur
none Details | Review
gtksourceview-2.patch (5.20 KB, patch)
2007-10-21 15:36 UTC, Ed Catmur
rejected Details | Review

Description Ed Catmur 2007-08-26 17:37:00 UTC
checking for DRIVEL... configure: error: Package requirements (
        glib-2.0 >= 2.4.0
        gmodule-2.0 >= 2.4.0
        gtk+-2.0 >= 2.4.0
        gconf-2.0 >= 2.0.0
        gnome-vfs-2.0 >= 2.6.0
        libgnome-2.0 >= 2.0.0
        libgnomeui-2.0 >= 2.0.0
        libglade-2.0 >= 2.0.0
        gtksourceview-1.0 >= 1.0.0
        libxml-2.0 >= 2.4.0
        libbonobo-2.0 >= 2.0.0
        bonobo-activation-2.0 >= 2.0.0
) were not met:

No package 'gtksourceview-1.0' found

gtksourceview-1.90.3 is installed.
Comment 1 Ed Catmur 2007-08-26 18:03:33 UTC
Created attachment 94383 [details] [review]

Suggested patch.
Comment 2 Ed Catmur 2007-10-21 15:36:55 UTC
Created attachment 97560 [details] [review]

Updated for 2.0.1
Comment 3 Elisamuel Resto 2008-01-13 16:00:14 UTC
This bug existed before 2.0.2 came out and it went ignored whist being such a short fix?

Is there any possibility to get this into a new version or even update the current version out? gtksourceview-2.x has been out for a while and drivel is still behind.
Comment 4 Neil Williams 2009-04-03 21:54:51 UTC
*** Bug 475089 has been marked as a duplicate of this bug. ***
Comment 5 Neil Williams 2009-04-03 22:20:11 UTC
I'll be testing this patch for possible inclusion into 2.0.4
Comment 6 Neil Williams 2009-04-05 13:43:18 UTC
Unfortunately, the proposed patch does not work properly - the code builds but when tested against gtksourceview2, most highlighting is disabled - e.g. <a href="test">foo</a> results in only the href being highlighted when the tag and the attribute are highlighted in the unpatched code. The current patch is not acceptable, I'm afraid.

Pushing this forwards to 2.1 when there will be more time to inspect the reasons for the failure. (Note, one obvious factor is that there is no lang-files-dirs property for the language_manager in version 2. I've tried testing with search-path without success - mime_types is getting no usable values returned so it looks like the language_manager_get_language_for_mime_type function (which the patch reimplements for v2.0) needs to be the focus for the work to fix the bug.)
Comment 7 Neil Williams 2009-04-05 13:46:41 UTC
OK, I was expecting bugzilla to process the tags - the actual draft I used for testing was:
$ cat 470479.draft 
<?xml version="1.0" encoding="UTF-8"?>
  <event>testing source markup and syntaxing &lt;a href="test"&gt;this should be a link&lt;/a&gt;
&lt;b id="attributes-work"/&gt;

Renders as:
testing source markup and syntaxing <a href="test">this should be a link</a>
<b id="attributes-work"/>

With the patch, only href= and id= got highlighted. Without the patch, <a, "test", <b and "attributes-work" were highlighted as normal.
Comment 8 Neil Williams 2009-06-26 19:48:50 UTC
The patch is not ready for 2.1 - I've updated a version in SVN that will at least build but it still fails to actually operate. Rejecting the patch.
Comment 9 Neil Williams 2009-07-12 18:08:52 UTC
*** Bug 585283 has been marked as a duplicate of this bug. ***
Comment 10 Neil Williams 2009-07-12 18:10:59 UTC
*** Bug 341739 has been marked as a duplicate of this bug. ***
Comment 11 Neil Williams 2009-07-12 18:12:25 UTC
*** Bug 438785 has been marked as a duplicate of this bug. ***
Comment 12 Neil Williams 2009-08-20 06:15:31 UTC
This is a Debian bug too:

Drivel 3.0 will use only libgtksourceview-2.0 but the actual implementation still needs to be fixed, dependent on how the other GTK3.0 changes go.