GNOME Bugzilla – Bug 466680
Top-level elements missing accessibility in Ekiga
Last modified: 2008-08-14 12:17:02 UTC
Many top-level menu elements of Ekiga are missing keystrokes for accessibility. Most are in place, but not all.
Created attachment 93657 [details] [review] Provide the missing accessible keystrokes for Ekiga
Looks neat. You can commit it to trunk. I guess Damien will tell you to commit to the stable branch too -- but I prefer him to confirm.
Thanks! My SVN account has problems, so if you could commit instead, I would appreciate it.
Hmmm... it doesn't apply to trunk. Could you check ? (I applied to gnome-2-14 branch -- hopefully Damien won't strangle me too much)
Perhaps the strings change needs to be announced. See http://live.gnome.org/Schedule I will do it.
I have created a new gnome-2-20 branch for Ekiga.
I unapplied from the gnome-2-14 branch. I'll apply to gnome-2-20 now.
I already did :)
Created attachment 95528 [details] [review] (trunk) Provide the missing accessible keystrokes for Ekiga Similar patch for trunk code.
I reviewed your last patch and it looks correct -- but I'm not sure it still applies, since the code moved a lot recently. Could you check?
Well the situation is the following : - either the code didn't move that much and the patch will apply more or less cleanly, which a beginner should be able to help with ; - or the code changed too much and the patch is unfortunately lost. :-( Marking this bug gnome-love, we'll see what it gives in another two weeks :-/
I worked on this issue. here are the diff of my changes on two files : lib/src/gmmmenuaddons.c src/gui/main.cpp Menu "Chat": Call CTRL+O Hang up Escape Add a new contact CTRL+O Hold call H Transfer call T Suspend audio M Suspend video P Menu "Edit": no more shortcut to access Preferences Menu "View": Show call panel CTRL+J Local video CTRL+1 Remote video CTRL+2 Picture-In-Picture CTRL+3 P-I-P in separate window CTRL+4 Normal size CTRL+0 Fullscreen F11 Menu "Tools": Find contacts CTRL+F I tried at maximum to respect the way shortcuts are adviced ini the HIG for Gnome apps.
Created attachment 111631 [details] [review] gmmenuaddon modification for new shortcuts
Created attachment 111632 [details] [review] main.cpp modification for new shortcuts
Finally fixed. Sorry for the HUGE delay, I am really ashamed but I had forgotten about this even though we talked about it during GUADEC. Sigh, I must be getting old :(