GNOME Bugzilla – Bug 453396
Team descriptions don't show up in list-teams
Last modified: 2007-07-11 15:04:36 UTC
Please describe the problem: In the list teams view, DL describes each team with the first language instead of the team description. Although this might be a feature and not a bug (because descriptions usually are big), some languages which have two scripts are given the title of one of the scripts. For example: "Norwegian Bokmål" instead of "Norwegian Nynorsk". Original bug report for Fedora at: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246606 Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: Patch: http://cvs.fedoraproject.org/viewcvs/web/flpweb/teams.py?root=l10n&r1=1.2&r2=1.3
The current design is indeed flawed. The Norwegian case is typical. "Norwegian Bokmål" in team list, "Norwegian nynorsk translation team" in team details... My idea would be to remove the "... Translation Team" part of the current description tags in translation-teams.xml.in, and adding systematically the "...translation team" as a suffix in the team details, either with the description or the first language. We could then use this description tag also in the team list. Example with no: <team id="no"> <_description>Norwegian (Bokmål, Nynorsk)</description> ... In team list: # Norwegian (Bokmål, Nynorsk) Coordinated by Kjartan Maraas In team details: Norwegian (Bokmål, Nynorsk) translation team When the description tag is omitted, simply use the first language by default, as it is now. Thoughts?
I think the latter won't translate correctly for some languages. The language name is OK by itself, but putting it in a sentence requires changing other words in it (plural etc).
I see your point, but if it is correctly written in code, it should translate correctly, like current code in teams.py: html.team['description'] = ( _("%(lang)s Translation Team") % { 'lang' : html.language_name } ) lang being replaced by description. Of course, it all depends on the comprehensiveness of all description tags.
Agreed. :) The original patch just corrects the team list to show up the description instead of the language.
It looks good, but I'd prefer to use the same logic as Claude quoted above when constructing the description. Either way, you're welcome to commit.
I implemented my solution in rev. 412. Hope it suits you Dimitris.