After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 453396 - Team descriptions don't show up in list-teams
Team descriptions don't show up in list-teams
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-07-03 14:50 UTC by Dimitris Glezos
Modified: 2007-07-11 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dimitris Glezos 2007-07-03 14:50:28 UTC
Please describe the problem:
In the list teams view, DL describes each team with the first language instead of the team description.

Although this might be a feature and not a bug (because descriptions usually are big), some languages which have two scripts are given the title of one of the scripts. For example: "Norwegian Bokmål" instead of "Norwegian Nynorsk".

Original bug report for Fedora at:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246606

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Patch:

http://cvs.fedoraproject.org/viewcvs/web/flpweb/teams.py?root=l10n&r1=1.2&r2=1.3
Comment 1 Claude Paroz 2007-07-04 13:02:07 UTC
The current design is indeed flawed. The Norwegian case is typical. 
"Norwegian Bokmål" in team list, "Norwegian nynorsk translation team" in team details...
My idea would be to remove the "... Translation Team" part of the current description tags in translation-teams.xml.in, and adding systematically the "...translation team" as a suffix in the team details, either with the description or the first language.
We could then use this description tag also in the team list.

Example with no:
  <team id="no">
     <_description>Norwegian (Bokmål, Nynorsk)</description>
     ...

In team list:

#  Norwegian (Bokmål, Nynorsk)
   Coordinated by Kjartan Maraas

In team details:

Norwegian (Bokmål, Nynorsk) translation team

When the description tag is omitted, simply use the first language by default, as it is now.

Thoughts?
Comment 2 Dimitris Glezos 2007-07-04 14:34:24 UTC
I think the latter won't translate correctly for some languages. The language name is OK by itself, but putting it in a sentence requires changing other words in it (plural etc).
Comment 3 Claude Paroz 2007-07-04 14:48:10 UTC
I see your point, but if it is correctly written in code, it should translate correctly, like current code in teams.py:

html.team['description'] = ( _("%(lang)s Translation Team")
                                                 % { 'lang' :
                                                     html.language_name } )
lang being replaced by description.

Of course, it all depends on the comprehensiveness of all description tags.
Comment 4 Dimitris Glezos 2007-07-04 15:03:45 UTC
Agreed. :)

The original patch just corrects the team list to show up the description instead of the language.
Comment 5 Danilo Segan 2007-07-09 13:44:09 UTC
It looks good, but I'd prefer to use the same logic as Claude quoted above when constructing the description.

Either way, you're welcome to commit.
Comment 6 Claude Paroz 2007-07-11 15:04:36 UTC
I implemented my solution in rev. 412. Hope it suits you Dimitris.