After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451710 - gnome_keyring_find_items keeps keyring locked
gnome_keyring_find_items keeps keyring locked
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.19.x
Other All
: Normal major
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-06-27 19:29 UTC by Jürg Billeter
Modified: 2007-06-28 00:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Jürg Billeter 2007-06-27 19:29:33 UTC
Calling gnome_keyring_find_items with a locked keyring will show the dialog asking to allow access for a specific applications but it never asks for the keyring password and therefore also never unlocks the keyring.

If the keyring is already unlocked gnome_keyring_find_items seems to work fine.

This is a regression of 2.19.4, if I remember correctly, and makes the keyring almost completely unusable for me, e.g. NetworkManager won't work after startup like that.
Comment 1 Stef Walter 2007-06-27 20:34:25 UTC
Will look into it. 
Comment 2 Stef Walter 2007-06-28 00:20:09 UTC
This was indicative of a far bigger problem. I've reworked some of the way that the prompts are built. The problem should be fixed. I've also added a unit test for this case.

2007-06-27  Stef Walter  <stef@memberwebs.com>

	* daemon/gnome-keyring-daemon-ops.c:
	* keyrings/gkr-keyring.c:
	* keyrings/gkr-keyring-item.c:
	* tests/unit-test-keyrings-prompt.c:
	* ui/gkr-ask-request.c:
	* ui/gkr-ask-tool.c: Properly unlock keyrings when finding, and 
	display item names by looking them up after the keyring is 
	unlocked. Fixes bug #451710