After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451568 - Make color selection process have "live" preview
Make color selection process have "live" preview
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Low enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-06-27 11:25 UTC by Tor Lillqvist
Modified: 2018-05-24 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.50 KB, patch)
2007-06-27 11:26 UTC, Tor Lillqvist 		committed Details | Review

Description Tor Lillqvist 2007-06-27 11:25:56 UTC 
This patch makes the color selector of at least the text tool have an immediately visible "live" preview effect upon the actual text layer visible in the image. This is kinda neat. (But still if one clicks "Cancel" on the color selector, it reverts back.)

As far as I can see there are no ill unintended side-effects. Having to use the block_setting_dialog_color flag is a bit ugly, but without that also the "old" color of the color selector got continuously updated.
Comment 1 Tor Lillqvist 2007-06-27 11:26:34 UTC 
Created attachment 90744 [details] [review]
Patch
Comment 2 Sven Neumann 2007-06-27 11:55:17 UTC 
2007-06-27  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpimagecommenteditor.[ch]: fixed spelling error.

	* app/widgets/gimpcolorpanel.[ch]: applied slightly modified patch
	from Tor Lillqvist that changes the ColorPanel to provide live
	updates (bug #451568).
Comment 3 Sven Neumann 2007-10-08 16:14:58 UTC 
As I expected earlier, this change is too invasive and causes breakage such as bug  #484757. I have now reverted the change (revision 22850). If a live update is considered a good thing in some places, then we should add API that allows to explicitly enable it for those places.
Comment 4 GNOME Infrastructure Team 2018-05-24 12:12:24 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/245.