After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441295 - audioconvert doesn't build on VS6
audioconvert doesn't build on VS6
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Windows
: Normal normal
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2007-05-25 22:03 UTC by Sebastien Moutte
Modified: 2007-05-31 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

proposed fix (540 bytes, patch)
2007-05-25 22:48 UTC, Tim-Philipp Müller
none Details | Review
patch to build audioconvert with vs6 (637 bytes, patch)
2007-05-27 16:03 UTC, Sebastien Moutte
accepted-commit_now Details | Review

Description Sebastien Moutte 2007-05-25 22:03:02 UTC
inline keyword is only available in C++ with VS6
__inline or __forceinline could be used in C
Comment 1 Tim-Philipp Müller 2007-05-25 22:48:50 UTC
Created attachment 88826 [details] [review]
proposed fix

This should fix it, I think. Can you confirm?
Comment 2 Jan Schmidt 2007-05-27 13:57:56 UTC
Is this a regression? Didn't we used to build on VS6 fine?
Comment 3 Sebastien Moutte 2007-05-27 16:02:55 UTC
yes, we did.
the fix should work but it doesn't.
There is something strange, inline is well defined in gutils.h but VS6 doestn't see it in float.h (may be a VS6 bug, don't know ...)
I propose a patch in attchment.
Comment 4 Sebastien Moutte 2007-05-27 16:03:48 UTC
Created attachment 88890 [details] [review]
patch to build audioconvert with vs6
Comment 5 Tim-Philipp Müller 2007-05-27 17:20:32 UTC
Have you tried #include <glib/glib.h> instead - maybe I got the wrong header for VS6? I think this fix belong elsewhere, either GLib or gst-compat or so.
Comment 6 Jan Schmidt 2007-05-28 10:08:48 UTC
from the code that wraps the INLINE defs in gutils.h, I suppose the problem may lie in the glibconfig.h that you have - does it properly define G_HAVE___INLINE ?

Comment 7 Sebastien Moutte 2007-05-30 20:35:35 UTC
including glib.h don't fix the problem.
And I've already check that glibconfig.h is well defining G_HAVE___INLINE by displaying a message at build time inside the #  elif defined (G_HAVE___INLINE) of gutils.h.
This is really strange.
I think this is a VS6 bug with keyword overwrite. if i add "#define tototo static" in the same place as the "#define inline __inline" is in gutils I can use it in floatcast.h without error.
Then i guess the last patch i proposed is the last solution :(
Comment 8 Jan Schmidt 2007-05-31 08:53:44 UTC
OK then, go for it.
Comment 9 Jan Schmidt 2007-05-31 16:38:11 UTC
Fixed in CVS:

2007-05-31  Jan Schmidt  <>

        * gst-libs/gst/floatcast/floatcast.h:
        Define inline when needed on win32 builds. Fixes: #441295