After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438840 - [theoradec] does not compile with old version of libtheora
[theoradec] does not compile with old version of libtheora
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2007-05-16 10:27 UTC by Edward Hervey
Modified: 2007-05-17 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Edward Hervey 2007-05-16 10:27:38 UTC
Compilation will fail with old versions of libtheora:

#theoradec.c: In function 'theora_handle_type_packet':
#theoradec.c:800: error: 'theora_info' has no member named 'pixelformat'
#theoradec.c:800: error: 'OC_PF_420' undeclared (first use in this function)
#theoradec.c:800: error: (Each undeclared identifier is reported only once
#theoradec.c:800: error: for each function it appears in.)

The above is with theora 1.0alpha4

A check should be added to configure scripts to check for the version of libtheora available and:
either not compile the plugin with old versions that don't have that symbol
OR compile with the relevant section #ifdef'd
Comment 1 Tim-Philipp Müller 2007-05-17 14:19:32 UTC
<__tim> thomasvs: is it ok to up the libtheora requirement to 1.0alpha5 (=FC5) or do we want to keep supporting older versions (like FC4 has) as well?
<thomasvs> dunno, what's the new higher version bring ?
<__tim> a pixelformat field in a theora struct that breaks compilation on older versions
<__tim> easy to add a configure check, but if we can up the requirement that's even better
<thomasvs> up it then

And so it was done:

  2007-05-17  Tim-Philipp Müller  <tim at centricular dot net>

          Bump libtheora requirement to 1.0alpha5 for the pixformat check
          (also has a .pc file, so we don't need the fallback check any
          longer). Fixes #438840.