After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436562 - Theoradec doesn't work well with gnonlin
Theoradec doesn't work well with gnonlin
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2007-05-07 11:31 UTC by Michael Smith
Modified: 2007-05-07 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Defer sending events until initialised (3.28 KB, patch)
2007-05-07 11:31 UTC, Michael Smith
committed Details | Review

Description Michael Smith 2007-05-07 11:31:14 UTC
When specifying a media-start of something other than zero, gnonlin doesn't like theora files.

Specifically, the problem is that gnonlin blocks theoradec's srcpad, and issues a seek as soon as that pad block triggers.

If it's triggered by an event (e.g. tags, newsegment), this seek can occur before the decoder has received all the headers. As a result, the headers are never received, so decode fails.

I'll attach a patch which defers sending newsegment and tag events until after the decoder is fully initialised.
Comment 1 Michael Smith 2007-05-07 11:31:40 UTC
Created attachment 87690 [details] [review]
Defer sending events until initialised
Comment 2 Edward Hervey 2007-05-07 11:34:18 UTC
apart from the fact that gst_element_found_tags_for_pad() does more than just push them (it also posts them on the bus), that patch is fine by me.