After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398179 - need a method to add any lastfm uri like "New Internet Radio Station"
need a method to add any lastfm uri like "New Internet Radio Station"
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: last.fm
unspecified
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-18 23:15 UTC by Marques Johansson
Modified: 2018-05-24 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for user radios (900 bytes, patch)
2009-01-02 13:33 UTC, Pascal Terjan
committed Details | Review

Description Marques Johansson 2007-01-18 23:15:47 UTC
Internet Radio streams can be added to the "Radio" list simply through the menu.

There is no such method for adding last.fm streams. A button should be added to the last.fm view or a menu entry "New Last.fm Radio Station" should be added (possibly only visible while on the last.fm view).

A lesser alternative would be to add other URL shortcuts to the "Similar Artists radio" drop-down.  This would have to include all possible lastfm base urls, such as:
"User's Personal radio" (lastfm://user/%s/personal)
"User's Loved radio" (lastfm://user/%s/loved)
"User's Recommended radio" (lastfm://user/%s/recommended/100)
"User's Neighbours radio" (lastfm://user/%s/neighbours)

Each entry would be added as "%s Loved radio" unless there is a better method to change %s to the possessive form.

There are also lastfm://play/tracks/{$id} urls, but I wouldn't expect anyone to know the number of a track they wanted to play.
Comment 1 Marques Johansson 2007-01-18 23:18:01 UTC
Another option, although less obvious to the user, would be to allow a user to add lastfm urls through the existing "New Internet Radio Station" dialog.
Comment 2 Alex L. Mauer 2008-04-29 06:08:26 UTC
I would suggest changing the "New Internet Radio Station..." menu entry to "New Last.fm Radio Station" while in the last.fm view.
Comment 3 Pascal Terjan 2009-01-02 13:33:35 UTC
Created attachment 125628 [details] [review]
Add support for user radios

I added patch my rhythmbox to add lastfm://user/%s/personal and lastfm://user/%s/loved because they are the main kind of lastfm radios I usually listen to, and then found out this bug.

So, I also added recommended and neighboors.

I attach the trivial patch here in case someone wants it, I think this is a quite important missing feature for lastfm users, and trivial to improve without waiting for a more general change in this part.
Comment 4 Jonathan Matthew 2009-01-03 09:52:15 UTC
Do you need to be a subscriber to use any of those new station types?  If so, we should hide those options if the user is not a subscriber.
Comment 5 marques 2009-01-03 13:59:29 UTC
I am a former subscriber, and I can still access all of these URIs.  I thought a friend's radio was only supposed to be available to subscribers.  It may be a bug on their end.

You could catch the error message they should provide and display it to offer the user to subscribe.  If you get complaints you can add an option to hide them.
Comment 6 Bastien Nocera 2009-01-03 18:14:05 UTC
See bug 563140 for links to check which radios are subscribers only.

http://www.last.fm/help/faq?category=Listening+to+Music+on+Last.fm#214
tells me that it's not subscriber only...
Comment 7 Jonathan Matthew 2009-03-11 13:47:14 UTC
I think it's only the loved tracks streams that are subscriber-only.  It's a bit ugly when you try to add your own loved tracks stream when you're not a subscriber - nothing happens, because the stream is already in the database, but it's hidden.

2009-03-11  Jonathan Matthew  <jonathan@d14n.org>

        patch by:  Pascal Terjan  <pascal.terjan@free.fr>

        * plugins/audioscrobbler/rb-lastfm-source.c:
        Add more last.fm stream types.  From #398179.
Comment 8 GNOME Infrastructure Team 2018-05-24 12:17:03 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/307.