Bug 378184 – g-s-p crash due to incorrect free from do_toggle_element

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 378184 - g-s-p crash due to incorrect free from do_toggle_element


Summary:	g-s-p crash due to incorrect free from do_toggle_element


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-good
Version:	0.10.4
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	0.10.5
Assigned To:	Tim-Philipp Müller
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Duplicates:	362021 409848 411545 411561 414999 416127 416524 417098 417549 420354 420392 422227 422441 422578 423049 423363 424392 424942 425205 425255 426649 427429 428085 429836 (view as bug list)
Depends on:
Blocks:

Reported:	2006-11-22 17:52 UTC by Sebastien Bacher
Modified:	2007-04-15 03:01 UTC

See Also:
GNOME target:	---
GNOME version:	2.15/2.16

Attachments
gconfaudiosrc: remove gconf notify when source is freed (2.38 KB, patch) 2006-12-11 09:22 UTC, Tim-Philipp Müller	committed	Details \| Review

Description Sebastien Bacher 2006-11-22 17:52:15 UTC

That bug has been opened on https://launchpad.net/distros/ubuntu/+source/control-center/+bug/72096

"I was trying to get my mic to work and it crashed

http://librarian.launchpad.net/5088761/_usr_bin_gnome-sound-properties.1000.crash
just crashed

Package: gnome-control-center 1:2.16.1-0ubuntu4"

Comment 1 Sebastien Bacher 2006-11-22 17:52:40 UTC

Debug backtrace:

+ Trace 88551

#0 free
from /lib/tls/i686/cmov/libc.so.6
#1 IA__g_free
at gmem.c line 187
#2 do_toggle_element
at gstgconfaudiosrc.c line 141
#3 notify_listeners_callback
at gconf-client.c line 2384
#4 gconf_listeners_notify
at gconf-listeners.c line 589
#5 notify_one_entry
at gconf-client.c line 2409
#6 notify_idle_callback
at gconf-client.c line 2449
#7 g_idle_dispatch
at gmain.c line 3926
#8 IA__g_main_context_dispatch
at gmain.c line 2045

Comment 2 Tim-Philipp Müller 2006-12-11 09:22:09 UTC

Created attachment 78117 [details] [review]
gconfaudiosrc: remove gconf notify when source is freed

Does this fix it?

Comment 3 Sebastien Bacher 2006-12-11 10:29:32 UTC

The crash looks like like something that happened once to that user and not easy to trigger, if you think that the patch is correct feel free to mark the bug as fixed

Comment 4 Tim-Philipp Müller 2006-12-11 11:44:26 UTC

Ah, I thought maybe you could reproduce it. I think this fixes it, I can't see anything wrong with the g_free stuff (it's not really thread-safe, but this shouldn't be an issue here since the gconf notify is always called from the same thread as the app here).

 2006-12-11  Tim-Philipp Müller  <tim at centricular dot net>

       * ext/gconf/gstgconfaudiosrc.c: (gst_gconf_audio_src_init),
       (gst_gconf_audio_src_dispose), (do_toggle_element):
       * ext/gconf/gstgconfaudiosrc.h:
         Remove gconf notify hook when the gconfaudiosrc element is
         destroyed, otherwise the callback may be called on an
         already-destroyed instance and bad things happen. Should fix
         #378184.
         Also ignore gconf key changes when the source is already running.

Comment 5 Tim-Philipp Müller 2007-01-23 21:59:56 UTC

*** Bug 362021 has been marked as a duplicate of this bug. ***

Comment 6 Jens Granseuer 2007-02-20 16:58:33 UTC

*** Bug 409848 has been marked as a duplicate of this bug. ***

Comment 7 Jens Granseuer 2007-02-24 12:16:17 UTC

*** Bug 411545 has been marked as a duplicate of this bug. ***

Comment 8 Jens Granseuer 2007-02-24 13:33:55 UTC

*** Bug 411561 has been marked as a duplicate of this bug. ***

Comment 9 Jens Granseuer 2007-03-05 18:25:13 UTC

*** Bug 414999 has been marked as a duplicate of this bug. ***

Comment 10 Jens Granseuer 2007-03-08 17:55:56 UTC

*** Bug 416127 has been marked as a duplicate of this bug. ***

Comment 11 Jens Granseuer 2007-03-09 18:14:38 UTC

*** Bug 416524 has been marked as a duplicate of this bug. ***

Comment 12 Jens Granseuer 2007-03-11 19:20:25 UTC

*** Bug 417098 has been marked as a duplicate of this bug. ***

Comment 13 Jens Granseuer 2007-03-12 18:35:45 UTC

*** Bug 417549 has been marked as a duplicate of this bug. ***

Comment 14 Jens Granseuer 2007-03-20 17:49:47 UTC

*** Bug 420354 has been marked as a duplicate of this bug. ***

Comment 15 Jens Granseuer 2007-03-20 17:50:31 UTC

*** Bug 420392 has been marked as a duplicate of this bug. ***

Comment 16 Jens Granseuer 2007-03-24 15:48:39 UTC

*** Bug 422227 has been marked as a duplicate of this bug. ***

Comment 17 Jens Granseuer 2007-03-24 23:08:07 UTC

*** Bug 422441 has been marked as a duplicate of this bug. ***

Comment 18 Jens Granseuer 2007-03-26 18:50:15 UTC

*** Bug 422578 has been marked as a duplicate of this bug. ***

Comment 19 Jens Granseuer 2007-03-27 19:24:19 UTC

*** Bug 423049 has been marked as a duplicate of this bug. ***

Comment 20 Jens Granseuer 2007-03-27 19:41:41 UTC

*** Bug 423363 has been marked as a duplicate of this bug. ***

Comment 21 Jens Granseuer 2007-04-01 13:31:52 UTC

*** Bug 424392 has been marked as a duplicate of this bug. ***

Comment 22 Jens Granseuer 2007-04-01 13:42:10 UTC

*** Bug 424942 has been marked as a duplicate of this bug. ***

Comment 23 Jens Granseuer 2007-04-01 18:28:04 UTC

*** Bug 425205 has been marked as a duplicate of this bug. ***

Comment 24 Jens Granseuer 2007-04-01 19:27:55 UTC

*** Bug 425255 has been marked as a duplicate of this bug. ***

Comment 25 Jens Granseuer 2007-04-05 16:18:44 UTC

*** Bug 426649 has been marked as a duplicate of this bug. ***

Comment 26 Pedro Villavicencio 2007-04-07 23:49:33 UTC

*** Bug 427429 has been marked as a duplicate of this bug. ***

Comment 27 Pedro Villavicencio 2007-04-10 01:07:45 UTC

*** Bug 428085 has been marked as a duplicate of this bug. ***

Comment 28 Pedro Villavicencio 2007-04-15 03:01:59 UTC

*** Bug 429836 has been marked as a duplicate of this bug. ***