GNOME Bugzilla – Bug 378165
Middle click paste onto smart bookmark
Last modified: 2008-08-04 13:24:49 UTC
This bug was reported to the Debian BTS. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369692 "I'm considering switching from galeon to epiphany... The feature I'm currently missing most is the ability to paste a URL into a tab directly. With galeon, I can middle-click-paste the URL to the new-tab button to get a new tab, or onto an existing tab. With firefox I think I can paste onto any place in the current frame to replace it with the new URL (I don't like this behaviour as much though) At least the paste-onto-new-tab-toolbar-icon behaviour should be added IMHO. It won't break anything, middle clicking on toolbar icons is completely unused afaict. That should be added for smart bookmarks, too. Currently if you middle-click on a smart bookmark, it will just open the non-smart URL in a new tab. IMHO it should use the pastebuffer contents for searching."
The paste-onto-new-tab-toolbar-icon behaviour is available with HEAD (2.17). See #149715. I'm trying to code the same behaviour for smart bookmarks: that's an interesting feature :)
That's very cool, thank you! :)
Middle click paste onto buttons now works in Epiphany. Is there any other reason why this is still open?
Heh, the reason for this bug to be still opened was to have it also for smart bookmarks...updating summary and patch following.
Created attachment 101207 [details] [review] enable middle click paste onto smart bookmark This patch basically adapts the code from ephy-home-action.c to ephy-bookmark-action.c.
+ ctx = g_new (ClipboardCtx, 1); Use g_slice_new (and g_slice_free later on). + if (event->button == 2) //middle click No C++ comments please. + gtk_clipboard_request_text + (gtk_clipboard_get_for_display (gdk_display_get_default(), + GDK_SELECTION_PRIMARY), Use gtk_widget_get_clipboard (entry). With these fixed, oktc. Thanks!
Created attachment 101208 [details] [review] committed patch Ok, thanks. I'm attaching here the committed patch for reference.
Closing as FIXED. ------------------------------------------------------------------------ r7784 | cosimoc | 2007-12-18 19:38:45 +0100 (mar, 18 dic 2007) | 3 lines Add middle-click-paste for smart bookmarks, as it is for new tab/window buttons. Close bug #378165.
I hate this new behaviour - is there any chance on making it a preference? epiphany 2.22.0 opens the smartbookmark with searchitem immediately, without giving the user to change the contents before actually launching it. I want to paste the clipboard contents into the textbox in the toolbar, modify/extend it and then launch the bookmark. And as for the nonsmart-URL that is opened when klicking the label, I'd really prefer the galeon way of solving it (i.e. add the possiblity to add a seperate non-smart URL - see bug #332900)
Reopening : this change is breaking common usage of paste on X Window. I agree for the new behaviour if paste is done on the button but if done in the entry field, it should be as before.
Agreed with Frederic, marking NEW again.
Created attachment 107495 [details] [review] patch Attached patch does not activate the entry after setting the text into it.
Thanks! Please commit to trunk and 2-24.
Committed to trunk and gnome-2-24, closing as FIXED. ------------------------------------------------------------------------ r8377 | cosimoc | 2008-08-04 15:17:47 +0200 (Mon, 04 Aug 2008) | 3 lines Bug #378165: do not activate the smart bookmark entry after middle-clicking paste text into it.