After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 375194 - Access violation parsing some border styles
Access violation parsing some border styles
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
0.6.x
Other Windows
: Normal blocker
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-14 17:06 UTC by Mark Rogers
Modified: 2006-11-14 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mark Rogers 2006-11-14 17:06:48 UTC
Access violation in cr_rgb_set_from_name parsing the following rule

.HPBottomBorders
{
border-bottom:SOLID 1px #ff9900;
border-top:SOLID 1px #ff9900;
}

It's running off the end of an array on this line:
        for (i = 0; i < sizeof (gv_standard_colors); i++) {

I think this line should read:
        for (i = 0; i < sizeof(gv_standard_colors)/sizeof(gv_standard_colors[0]); i++) {

Similarly
        if (i < sizeof (gv_standard_colors))
should read:
        if (i < sizeof (gv_standard_colors)/sizeof(gv_standard_colors[0]))
Comment 1 Dominic Lachowicz 2006-11-14 17:14:45 UTC
Thanks for the bug report. I applied a similar patch to the one you suggested.