After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 366499 - New layout for toolbar
New layout for toolbar
Product: rhythmbox
Classification: Other
Component: User Interface
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Reported: 2006-10-28 21:03 UTC by Luca Ferretti
Modified: 2013-10-02 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

A Glade mochup of proposed layout (17.26 KB, application/x-glade)
2006-10-28 21:06 UTC, Luca Ferretti
A screenshot of proposed layout, if you don't have Glade 3 (31.28 KB, image/png)
2006-10-28 21:08 UTC, Luca Ferretti

Description Luca Ferretti 2006-10-28 21:03:48 UTC
The current toolbar has 3 issues:
  * the play button is a toggle button, but it's placed between 2
    "simple" buttons; HIG should suggest to not mix different buttons
    (as well as menu items)
  * the volume button has no label
  * there are some source-related buttons appearing on toolbar

##### Play button ####

The fix for the first issue is simple: change the layout from

   Prev | Play | Next


   Play <sep> Prev | Next

(<sep> is a separator, | button bounds)

#### Volume button ####

The fix for volume button is unknown to me. I've to scrub libbacon imported widget.

#### Appearing buttons ####

The fix for appearing buttons could be inspired to Tomboy. Editing a note in Tomboy, you can use two menu-buttons in toolbar: those buttons don't perform any action, but open a menu with available actions. It's just like the Back/Forward buttons in web browser, where you can browse the history with the little down arrow, just the button open the menu when you click on the icon too.

So, we could add an "Actions" GtkMenuToolButton to toolbar. The button will open a menu with general and source related menu entries (max 10 items, as per HIG), for example

   [x] Show Browser
       New Playlist
       New Smart Playlist
       Add to Playlist  >
       Burn to CD...
       Import Folder

where "Show Browser" and "Import Folders" could be always showed. Of course we have to investigate items to put in this menu.

#### Proposed layout ####

This is the layout I propose for toolbar

   Play <sep> Next | Prev <sep> Actions* //// Shuffle | Repeat <sep> Volume

where //// is empty space (i.e. Shuffle, Repeat and Volume should be right aligned.
Comment 1 Luca Ferretti 2006-10-28 21:06:10 UTC
Created attachment 75578 [details]
A Glade mochup of proposed layout

WARNING: I've used GLADE 3, I'm not sure you can open it in GLADE 2.
Comment 2 Luca Ferretti 2006-10-28 21:08:58 UTC
Created attachment 75579 [details]
A screenshot of proposed layout, if you don't have Glade 3
Comment 3 Luca Ferretti 2006-10-28 21:11:33 UTC
PS I don't know is this change could be applied with current GTK+ version requested by Rhythmbox.
Comment 4 Jonathan Matthew 2006-10-28 23:11:31 UTC
The 'actions' menu button seems odd to me.  Most of the items that would appear in it are already in the regular menu.
Comment 5 Jean-François Fortin Tam 2013-10-02 18:42:23 UTC
Fixed in 3.0.