After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 364956 - Caps incompatibilities for AMR
Caps incompatibilities for AMR
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-25 10:49 UTC by Laurent Glayal
Modified: 2006-10-25 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
change 'audio/AMR', 'audio/AMR-WB' to 'audio/x-amr-nb', 'audio/x-amr-wb' for gst-plugins-bad (1.35 KB, patch)
2006-10-25 10:50 UTC, Laurent Glayal
rejected Details | Review
same as previous patch for gst-plugins-good (881 bytes, patch)
2006-10-25 10:51 UTC, Laurent Glayal
rejected Details | Review
same as previous patch for gst-plugins-ugly (1.54 KB, patch)
2006-10-25 10:51 UTC, Laurent Glayal
rejected Details | Review

Description Laurent Glayal 2006-10-25 10:49:03 UTC
Most amr elements use 'audio/AMR' as encoding name, but ffmux_mov rely on 'audio/x-amr-nb' encoding name.

Elements using 'audio/AMR' or 'audio/AMR-WB' :

rtpamrdepay
rtpamrpay

amrwbparse
amrwbdec
amrwbenc
qtdemux

amrnbparse
amrnbdec
amrnbenc
Comment 1 Laurent Glayal 2006-10-25 10:50:38 UTC
Created attachment 75357 [details] [review]
change 'audio/AMR', 'audio/AMR-WB' to 'audio/x-amr-nb', 'audio/x-amr-wb' for gst-plugins-bad
Comment 2 Laurent Glayal 2006-10-25 10:51:08 UTC
Created attachment 75358 [details] [review]
same as previous patch for gst-plugins-good
Comment 3 Laurent Glayal 2006-10-25 10:51:35 UTC
Created attachment 75359 [details] [review]
same as previous patch for gst-plugins-ugly
Comment 4 Laurent Glayal 2006-10-25 10:57:30 UTC
attached patch modify encoding name to 'audio/x-amr-nb' and 'audio/x-amr-wb'
Comment 5 Wim Taymans 2006-10-25 15:03:55 UTC
uhm... if most element use audio/AMR and only one element uses audio/x-amr-nb, maybe that would suggest that only one element is wrong...
Comment 6 Laurent Glayal 2006-10-25 15:11:34 UTC
But gst-ffmpeg is coherent for all its codec and many different elements too, encoding names mostly have a pattern 'media/x-name-other'.
Comment 7 Wim Taymans 2006-10-25 16:48:29 UTC
I changed audio/x-amr-nb to audio/AMR because it is closer to an officially registered mime type and might therefore improve interoperability. I apparently forgot to change the ffmpeg muxer...
Comment 8 Wim Taymans 2006-10-25 17:20:53 UTC
        * ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
        (gst_ffmpeg_caps_to_codecid):
        Fix AMR caps. Fixes #364956.

        * ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_get_stream):
        Activate pads before adding them.