GNOME Bugzilla – Bug 361333
Ability to filter or reset toplevel tag in tag sidebar
Last modified: 2018-07-12 00:11:03 UTC
I wrote a patch that allows you to choose the toplevel tag for the sidebar on the fly, to help manage tag-creep.
Created attachment 74457 [details] [review] Patch
Hi Gabriel, one minor thing to change to make it 'solid' ;) : if you open the filter widget with Ctrl-L, the checkmenu item in the View menu became out of sync...
quick fix (no time to make a proper patch right now) public void HandleFilterTags (object sender, EventArgs args) { + display_tag_filter_menu_item.Active = true; tagview_filter_box.Show (); tagview_filter.Entry.GrabFocus (); }
Created attachment 74530 [details] [review] Updated This version incorporates Stephane's fix, and changes the behavior somewhat, supporting tags that don't have children much better, and showing you the tag whose name you typed in addition to its children, instead of just its children.
Created attachment 74531 [details] [review] Same version, including the new file this time
Just tested this and it works great. To remain consistant with other GNOME apps I would put the Clear button on the right, and remove the drop down list, replacing it with a simple Entry field
Comment on attachment 74531 [details] [review] Same version, including the new file this time Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
F-Spot has moved to https://github.com/f-spot/f-spot/issues If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub. Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.