After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360650 - Move Music->Close menu item to View->Hide Window
Move Music->Close menu item to View->Hide Window
Status: RESOLVED NOTABUG
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 396380 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-08 14:08 UTC by Luca Ferretti
Modified: 2009-12-28 05:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A simple patch to fix this bug (2.12 KB, patch)
2006-10-08 14:11 UTC, Luca Ferretti 		none Details | Review

Description Luca Ferretti 2006-10-08 14:08:51 UTC 
The Music->Close menu item is, simply, wrong: see HIG (http://developer.gnome.org/projects/gup/hig/2.0/menus-standard.html) for the proper usage of Close menu item. GNOME users expect this behavior.

So IMHO is better move this feature in View menu, renaming as "Hide Window"
Comment 1 Luca Ferretti 2006-10-08 14:11:06 UTC 
Created attachment 74291 [details] [review]
A simple patch to fix this bug

The patch change the GtkAction name from MusicClose to MusicHide and place it under View menu using "_Hide Window" as label.

I suspect we should also update documentation after applying this patch.

PS OK to commit?
Comment 2 Alex Lancaster 2006-10-09 01:15:22 UTC 
Adding HIG keyword.
Comment 3 Alex Lancaster 2007-01-16 07:50:30 UTC 
*** Bug 396380 has been marked as a duplicate of this bug. ***
Comment 4 Andy Hanton 2009-05-13 14:51:27 UTC 
I think that the Music -> Close menu item should do the same thing as the close button on the window frame.  If the minimize to tray plugin is active, the menu item should minimize the window to the tray.  If the plugin isn't active, the close menu should close the window and quit Rhythmbox.  Having two different behaviors for two ui elements labeled 'close window' causes confusion.  For example, some people claim that rhythmbox minimizes to the tray when the window is closed, while others claim that it doesn't.  Both groups are correct because there are two distinct actions labeled 'close window'.
Comment 5 Jonathan Matthew 2009-12-28 05:05:33 UTC 
I believe our usage of the 'close' menu item is now correct.