After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356380 - Composition doesn't find the next stop correctly with operations.
Composition doesn't find the next stop correctly with operations.
Product: GStreamer
Classification: Platform
Component: gnonlin
git master
Other All
: Normal normal
: 0.10.6
Assigned To: Edward Hervey
Edward Hervey
Depends on:
Reported: 2006-09-17 11:38 UTC by Jono Bacon
Modified: 2006-11-02 10:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

test script (5.42 KB, text/plain)
2006-09-17 11:39 UTC, Jono Bacon
glade file for use with test script (2.75 KB, application/xml)
2006-09-17 11:39 UTC, Jono Bacon
Proposed fix (4.53 KB, patch)
2006-10-06 07:52 UTC, Edward Hervey
committed Details | Review

Description Jono Bacon 2006-09-17 11:38:02 UTC
Please describe the problem:
When creating two gnloperations on the same composition, at the point where they overlap, they both don't exectute, and only one does. In the attached script, only one operation (the lowpass effect) applied to the audio, and the second operation (the phaser) is not applied, despite the priorities being correct.

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Jono Bacon 2006-09-17 11:39:17 UTC
Created attachment 72930 [details]
test script
Comment 2 Jono Bacon 2006-09-17 11:39:55 UTC
Created attachment 72931 [details]
glade file for use with test script
Comment 3 Edward Hervey 2006-09-30 15:48:27 UTC
There's nothing wrong with the script you provide:

You've put:
gnlfilesource 0s -> 60s with priority 2
phaserII 10s -> 15s with priority 2 (Same priority as something else, you're going straight to the wall here)
lowpass-iir 5s -> 30s with priority 1

According to that the following should happen (and does):
From 0s -> 5s : only gnlfilesource
From 5s -> 30s : lowpass-iir over gnlfilesource
From 30s-> 60s : only gnlfilesource

On the other hand, if you put phaserII to priority 1 and lowpass-iir to priority 0 (which is maybe what you intended), it doesn't play phaserII.

Modifying the title accordingly.
Comment 4 Edward Hervey 2006-10-06 07:52:48 UTC
Created attachment 74116 [details] [review]
Proposed fix

With this patch, the next stop is modified so it looks for the next change position which is:
_ after the stack start position (not-included)
_ with a priority higher than the HIGHEST priority in the stack
Comment 5 Edward Hervey 2006-11-02 10:15:31 UTC
2006-11-02  Edward Hervey  <>

	* gnl/gnlcomposition.c: (gnl_composition_ghost_pad_set_target),
	(next_stop_in_region_above_priority), (convert_list_to_tree),
	(get_stack_list), (get_clean_toplevel_stack),
	Better check for the 'next stop' of a stack. It will now look at all
	objects under the highest priority (and not the lowest as previously).
	Fixes #356380.
	Set new pads as active.
	Add some debug.