After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351437 - [PATCH] ffmpeg postproc ported to 0.10
[PATCH] ffmpeg postproc ported to 0.10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.1
Other Linux
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-15 11:46 UTC by Mark Nauwelaerts
Modified: 2006-10-20 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch implementing port to 0.10 (34.71 KB, patch)
2006-08-15 11:52 UTC, Mark Nauwelaerts
none Details | Review

Description Mark Nauwelaerts 2006-08-15 11:46:11 UTC
Subject says it all :)
Also an enhancement: the parameters of the filters are exposed as properties.
Comment 1 Mark Nauwelaerts 2006-08-15 11:52:43 UTC
Created attachment 70940 [details] [review]
Patch implementing port to 0.10

Patch as indicated, note that:
- GstVideoFilter (and therefore GstBaseTransform) is now used as a base class
- liboil is introduced as a requirement (in configure.ac), as it is used for determining cpu-flags
- gstpostproc.h is no longer used (did not contain much), and all mentioning of it could be removed (thereby avoiding any confusion), as the file itself (??)
Comment 2 Edward Hervey 2006-08-15 13:01:31 UTC
Nice work. I'm reviewing the patch. I also had some ideas about the properties.
Comment 3 Edward Hervey 2006-10-20 15:18:03 UTC
Now commited to CVS. Thanks again,

2006-10-20  Mark Nauwelaerts <manauw@skynet.be>

        Reviewed by: Edward Hervey  <edward@fluendo.com>

        * configure.ac:
        postproc filters need liboil to detect the cpu architecture
        * ext/libpostproc/Makefile.am:
        Update for liboil requirement, libpostproc being moved around in
        ffmpeg mirror, and removal of unused header file.
        * ext/libpostproc/gstpostproc.h:
        Header file not needed anymore
        * ext/libpostproc/gstpostproc.c: (gst_pp_scope_get_type),
        (change_context), (append), (change_mode),
        (gst_post_proc_base_init), (gst_post_proc_class_init),
        (gst_post_proc_init), (gst_post_proc_dispose),
        (gst_post_proc_setcaps), (gst_post_proc_transform_ip),
        (gst_post_proc_set_property), (gst_post_proc_get_property),
        (gst_post_proc_deblock_set_property),
        (gst_post_proc_deblock_get_property),
        (gst_post_proc_tmpnoise_set_property),
        (gst_post_proc_tmpnoise_get_property),
        (gst_post_proc_autolevels_set_property),
        (gst_post_proc_autolevels_get_property),
        (gst_post_proc_forcequant_set_property),
        (gst_post_proc_forcequant_get_property), (gst_post_proc_register),
        (plugin_init):
        Port of postprocessing elements to 0.10.