GNOME Bugzilla – Bug 348050
[New extension] Creative Commons license viewer
Last modified: 2006-10-10 21:17:34 UTC
I've coded a new extension in Python called "Creative Commons license viewer". It shows a "CC" icon on the statusbar if the current web has a Creative Commons license. If the user clicks on the icon, a new tab shows the license from <a href="http://www.creativecommons.org">www.creativecommons.org</a> . Its aim is similar to the <a href="http://bugzilla.gnome.org/show_bug.cgi?id=170996">Bug #170996</a>, but I think that is better to show an icon on the statusbar rather than to display the license's details on the page info extension. I wonder if this extension could be included in the 2.16 release cycle.
Created attachment 69197 [details] Creative Commons license viewer extension
Created attachment 69541 [details] Creative Commons license viewer extension 0.2 Fixed in this version: - No external image is needed, it is included inline - Internationalization support
Created attachment 71985 [details] Some enhancements I reviewed your code and rewrote it a bit (heh, but not so much :) ) today. The main problem is that the extension try to detect the license each time a page is loaded but also each time you switch from tab to tab.
First fo all, thanks for reviewing and correcting my code :-) I knew my code had that problem. I tried to solve it asking the epiphany-devel list (http://mail.gnome.org/archives/epiphany-list/2006-July/msg00013.html), but I got no response. I reviewed your code and now that problem is solved. Is there any other thing to correct or can it be included in the official epiphany-extension package?
Created attachment 72216 [details] Optimization The pixbuf is built one time and not each time the extension is attached to a window. Also, I found some sites not detected as cc by the extension: - http://www.gnome-ev.de/index.php/Hauptseite - http://blogs.law.harvard.edu/stickbug/ Could you have a look to these sites and perhaps to make the extension more "generic" ?
One comment about your new review: why do you import the time module in the detect_license function if you don't use it? I've had a look at both of them and they have the same problem: they don't follow the instructions in http://creativecommons.org/text/publish-website to add a metadata license to a web, so the license detector doesn't work witk them. The solution could be to add a more complex detector using external libraries, but this means adding new dependencies and I'm not sure if this is right for a simple epiphany-extension. IMHO, users should add metadata the right way to their webs instead of just adding an image linking to the license deed.
Is it possible to show a warning or a (!) instead of the CC logo where the license is badly defined?
Jaime, I just talked to chpe on irc. If crispin and/or jfr are ok with it, you're free to commit. jfr?
It is ok for me (I like to use this extension), so, Jaime, you're free to commit. If you have not the rights, tell me, I will commit for you.
Added to the development version. Thank you for this new extension.