After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347673 - firefox doesn't do DnD to nautilus
firefox doesn't do DnD to nautilus
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.15.x
Other All
: Normal normal
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-16 13:45 UTC by sangu
Modified: 2006-08-11 21:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (25.47 KB, patch)
2006-07-20 19:25 UTC, Christian Neumair
committed Details | Review
Proposed NautilusFileOperation patch (1.70 KB, patch)
2006-07-27 22:24 UTC, Christian Neumair
committed Details | Review

Description sangu 2006-07-16 13:45:04 UTC
Please describe the problem:
firefox doesn't do Drag And Drop to nautilus
[...]
(nautilus:2590): Eel-CRITICAL **: eel_vfs_has_capability_uri: assertion `uri != NULL' failed

(nautilus:2590): libgnomevfs-CRITICAL **: gnome_vfs_uri_unref: assertion `uri != NULL' failed


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
yes, always.

Other information:
gnome-vfs2-2.15.3, nautilus-2.15.4, eel-2.15.4
OS : Fedora rawhide 20060716
Comment 1 Christian Kellner 2006-07-16 13:55:44 UTC
That works just fine from epiphany. No idea how this could be the fault of gnome-vfs. We don't handle drag and drop at all, the application takes care of that. This is either a firefox or nautilus bug *IMHO*. 
Comment 2 sangu 2006-07-16 14:22:31 UTC
The same problem happens in epiphany-1.15.1.
And when doing DnD text on firefox or epiphany, a error dialog popup with below message.
"Error creating new document."
"Error "Invaild type" creating new document."

Comment 3 Christian Kellner 2006-07-16 14:31:30 UTC
epiphany 1.15? You prolly mean 2.15. I have 2.15.4 here and it works just fine. Still I don't see how this is a gnome-vfs problem. 
Comment 4 Christian Neumair 2006-07-16 20:23:14 UTC
Maybe it's a result of our recent Nautilus drag changes. What are you trying to drag? Text, an URL? Are you using the icon view or the list view?

Maybe you could play around a bit and report the precise circumstances? :)
Comment 5 sangu 2006-07-17 02:58:56 UTC
Text, image, URL.
Text  has error dialog message,but image and URL don't have error dialog message. 
and trying to DnD text on gedit, the same problem happens.
DnD  doesn't work on Desktop.
But  DnD to opened nautilus window.
Doing Ctrl+R, file appears in nautilus window. 
Comment 6 Christian Neumair 2006-07-20 19:25:26 UTC
Created attachment 69273 [details] [review]
Proposed patch

Thanks for your help!

The attached patch renames the single-URL drag target so that it gets obvious that it should be used by Netscape only, and removes all the drag sources we registered with it, leaving only the drag targets. That allows us to swap it with "text/uri-list" and fetch all the URIs from browsers as "_NETSCAPE_URL". Dragging from the location bar of a browser seems to work fine with it.

I assume the decision to use "_NETSCAPE_URL" for moving files and not just weblinks is a legacy from GMC days, possibly before "text/uri-list" was established.

Note that the location bar "_NETSCAPE_URL" drop target for the location bar was deliberately removed, because dropping weblinks to it doesn't make much sense IMHO.

It also special-cases desktop, trash and search URIs in the affected file operation helpers, so that dragging for the desktop isn't broken anymore, and makes some of the helpers more robust as ((uri = gnome_vfs_uri ("foo") != NULL) failure.
Comment 7 Alexander Larsson 2006-07-27 14:08:04 UTC
I also got reports on problems dnding from the panel:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200398
might be related
Comment 8 Christian Neumair 2006-07-27 22:20:32 UTC
The patch was committed (slightly modified).
Comment 9 Christian Neumair 2006-07-27 22:24:49 UTC
Created attachment 69771 [details] [review]
Proposed NautilusFileOperation patch

The attached patch improves the file operation handling for the desktop URI, which reenables me to drag panel launchers to the desktop. Not to pretty but effective.
Comment 10 Jose M. daLuz 2006-07-28 23:43:21 UTC
*** Bug 348185 has been marked as a duplicate of this bug. ***
Comment 11 Alexander Larsson 2006-08-08 09:17:42 UTC
Commited last patch.
Comment 12 Christian Neumair 2006-08-11 21:05:14 UTC
Marking last patch as committed.