Created attachment 67426 [details] [review]
gnomeicu-BNC-159099.patch

v7newuser.c:146: warning: comparisons like X<=Y<=Z do not have their
mathematical meaning
v7recv.c:384: warning: comparisons like X<=Y<=Z do not have their mathematical
meaning

Reference:
https://bugzilla.novell.com/show_bug.cgi?id=159099

Created attachment 67428 [details] [review]
gnomeicu-implicit-declaration.patch

Fixes all implicit declaration warnings. On 64 bit platforms, these warnings can cause random crashes, because compiler has no information about data type width.

Created attachment 67429 [details] [review]
gnomeicu-void.patch

Fixes invalid use id g_return_if_fail() in non-void functions.

Author: Gary Ekker

Created attachment 67430 [details] [review]
gnomeicu-random-return.patch

Fixes (possible) random return value warning.

Created attachment 67431 [details] [review]
gnomeicu-uninitialized.patch

Attempt to fix variable used before set warnings. Please carefully review this patch and think twice before applying. Fix may be incorrect.

Partial reference: https://bugzilla.novell.com/show_bug.cgi?id=184318

And finally, "no" locale is deprecated and files should be renamed to "nb":

rename no nb po/no.*
sed -i "s/\(ALL_LINGUAS.*\) no /\1 nb /" configure.in

Created attachment 67433 [details]
gnomeicu-warnings.log

Remaining warnings after applying all these patches while compiling with gcc 4.1.0.

Note that you can also remove obsolete acinclude.m4 (and call aclocal and/or autoreconf to update aclocal.m4), because AM_PATH_ESD is no more used.

thanks for the patches, I'll apply them.

I applied everything except the second patch in attachement 67431 which seems wrong to me.

Thanks for you work.

OK, my fix is bad, but bug is real:

v7recv.c: In function 'v7_advanced_message':
v7recv.c:774: warning: 'here' is used uninitialized in this function

I believe this one has already been fixed in the CVS head.