After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331582 - [qtdemux] protect log statement against invalid memory access
[qtdemux] protect log statement against invalid memory access
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-02-17 18:11 UTC by Tim-Philipp Müller
Modified: 2006-02-19 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

fix (1.32 KB, patch)
2006-02-17 18:13 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2006-02-17 18:11:35 UTC
The patch to follow prevents invalid memory in the GST_LOG_OBJECT statement by protecting it with a if (index < index_size). This only affects quicktime streams that contain still images or other 'empty' streams AFAIK.
Comment 1 Tim-Philipp Müller 2006-02-17 18:13:54 UTC
Created attachment 59600 [details] [review]
Comment 2 Jan Schmidt 2006-02-17 18:15:51 UTC
Please commit
Comment 3 Tim-Philipp Müller 2006-02-17 18:30:57 UTC
Committed, thanks:

2006-02-17  Tim-Philipp Müller  <tim at centricular dot net>

       * gst/qtdemux/qtdemux.c: (gst_qtdemux_loop_state_movie):
         Don't GST_LOG timestamps from nonexistent index
         entries (#331582).