After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330597 - Forwarding messages with HTML attachment does not keep the attachment
Forwarding messages with HTML attachment does not keep the attachment
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
: 537125 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-09 23:24 UTC by Steve Auerbach
Modified: 2009-11-05 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed evo patch (1.43 KB, patch)
2008-06-04 17:55 UTC, Milan Crha 		committed Details | Review

Description Steve Auerbach 2006-02-09 23:24:00 UTC 
Please describe the problem:
When I forward a message with an attachment which
is a text file, spreadsheet, etc., using "Forward style: Inline", or
"Forward style: Quoted" the message is included in the text of my email,
and the attachments are attached. But, if the attachment is an HTML
file, the text is included, but the attachment is missing.

Steps to reproduce:
1. Set "Forward Style" to "inline" or "quoted"
2. Forward the message
3. 


Actual results:
The HTML file which should be attached, is not attached

Expected results:
HTML file in the message which is being forwarded should be attached to the
forwarded message

Does this happen every time?
Yes

Other information:
No
Comment 1 Poornima 2006-02-10 04:16:19 UTC 
Could'nt find duplicate, so confirming this bug.
Comment 2 Milan Crha 2008-06-04 16:30:43 UTC 
I can reproduce this with actual trunk, even with text/plain attachment.
Comment 3 Milan Crha 2008-06-04 17:55:07 UTC 
Created attachment 112156 [details] [review]
proposed evo patch

for evolution;

I really do not know why it was done like this, but it stripped all text/* parts and all sub-messages attached into the original message. I changed it, the text/* parts are stripped only if doesn't have the filename set, the submessages are also attached. There is only one thing, the text body of the submesage is shown in the new message body too. It would make it strange, maybe?
Comment 4 Srinivasa Ragavan 2008-06-06 10:09:39 UTC 
Can you guys review it ?
Comment 5 Srinivasa Ragavan 2008-06-13 03:41:54 UTC 
** Timeout ** 

Milan, commit it to trunk. Test it, as I haven't done that. The code path seems fine to me.
Comment 6 Milan Crha 2008-06-13 06:36:50 UTC 
Committed to trunk. Committed revision 35634.
Comment 7 Milan Crha 2009-11-05 14:47:17 UTC 
*** Bug 537125 has been marked as a duplicate of this bug. ***