GNOME Bugzilla – Bug 330411
Support transcoding data sent to DAAP clients
Last modified: 2018-05-24 11:22:53 UTC
This may be expected behavior unless the ogg plugin is installed. However, the song information shows that it is a MPEG file and there is no feedback or error message. I suppose we can either convert the file on the fly or indicate somehow that this is an ogg file which iTunes can report that it doesn't support.
I have the ogg plugin installed, and it still doesn't appear to work because iTunes thinks it is mpeg audio. Converting on the fly would cause issues for people using RB (or Banshee et al) who don't have an mp3 decoder. Going on the user-agent would be hard, since we report ourselves as iTunes, because iTunes doesn't like other client connecting.
There's a field in the DAAP song description for the song format. Perhaps we're not setting it correctly: const gchar *filename; gchar *ext; filename = rhythmdb_entry_get_string (entry, RHYTHMDB_PROP_LOCATION); ext = strrchr (filename, '.'); if (ext == NULL) { /* FIXME we should use RHYTHMDB_PROP_MIMETYPE instead */ ext = "mp3"; rb_daap_structure_add (mlit, RB_DAAP_CC_ASFM, ext); } else { ext++; rb_daap_structure_add (mlit, RB_DAAP_CC_ASFM, ext); } or perhaps itunes isn't requesting the field.
We should really use g_utf8_strrchr(), but that wouldn't cause this bug. Does anyone know what exactly should be the data for RB_DAAP_CC_ASFM? It being the file extension instead of a mime-type (or something) sounds odd.
Neither using the mime type for the ASFM field nor setting the content-type header in the HTTP response containing the file helps. Interestingly, itunes doesn't seem to include ogg files in the song lists it sends to daap clients. I think itunes just sucks in this regard.
Unless we want to add some funky transcode-to-iTunes-playable-format code to the daap sharing, I think this can be marked NOTGNOME (as it affects every daap server).
Marking as enhancement and re-titling.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/145.