GNOME Bugzilla – Bug 330089
[bz2] Wrong mimetype and no typefinding
Last modified: 2006-02-06 18:26:06 UTC
great news, the bz2 plugin has landed in CVS.
But there are a couple of issues.
1/ The plugin uses the "application/x-bz2" mimetype for compressed stream, whereas the gstreamer typefind functions will use the "application/x-bzip" mimetype for bz2 streams.
2/ bz2enc should allow any caps for it's sinkpad
3/ bz2dec should do internal typefinding in order to give the proper caps on it's srcpad (and not application/octet-stream which will never connect to anything when used by decodebin).
For examples of internal typefinding see id3demux.
Lutz, could you have a look at these? Feel free to ask if you have questions. We are also available in #gstreamer on freenode.
Created attachment 58818 [details] [review]
Fixes for (1), (2) and (3).
you're fast :)
2006-02-06 Lutz Mueller <firstname.lastname@example.org>
Reviewed by: Edward Hervey <email@example.com>
* ext/bz2/gstbz2enc.c: Accepd "ANY" caps. Use "x-bzip" instead of
* ext/bz2/gstbz2dec.c: Use "x-bzip" instead of "x-bz2". Initial
caps are "ANY".
(gst_bz2dec_chain): Configure the source pad if we can figure out
the mime type of the decompressed data.
(gst_bz2dec_class_init: New property "first_buffer_size".