GNOME Bugzilla – Bug 324813
numbers of the remaining time in the copy dialog are not padded with zero
Last modified: 2006-12-19 14:46:59 UTC
Please describe the problem: The numbers of the remaining time in "Copying files" dialog are not padded with zero. Please see attached screenshot. Steps to reproduce: 1. Copy files and observe the "Copying files" dialog. Actual results: Times like "2:38:1" in the screenshot are displayed. Expected results: Times are displayed with padded zeros like "2:38:01". Does this happen every time? Yes. Other information:
Created attachment 56301 [details] screenshot
Thanks for your bug report, good catch! I'm milestoning this one to 2.14. We should probably use the same construct as the epiphany download manager, which uses "%u:%02u.%02u" if more than one hour remains, and otherwise "%d:%02d". I'd really appreciate if you could tackle this and write a patch - this is not rocket science. The strings are in libnautilus-private/nautilus-file-operations-progress.c:time_remaining_callback. For the sake of consistency, we should IMHO change time strings in the str variable assignments to "%d:%02d:%02d" and "%02d:%02d".
Created attachment 77659 [details] [review] pad seconds with zero in copy progress dialog I don't know any C, I've never created a patch before and I have no idea how to build Nautilus, so I can't check if this actually works, but here is a patch anyway. I didn't pad the minutes in the minutes:seconds string with zero, because I think the extra zero at the beginning isn't really needed.
Thanks for your effort, I committed a similar patch from bug 376291. *** This bug has been marked as a duplicate of 376291 ***