After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324353 - All tracks have a bitrate of 0 KB/Second
All tracks have a bitrate of 0 KB/Second
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 2.x
Assigned To: Ruben Vermeersch
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-17 20:11 UTC by Thijs Vermeir
Modified: 2006-04-09 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch v1 (1.82 KB, patch)
2006-01-10 13:40 UTC, Koike Kazuhiko 		none Details | Review
patch v2 (3.36 KB, patch)
2006-01-14 01:29 UTC, Koike Kazuhiko 		none Details | Review
patch v3 (1.68 KB, patch)
2006-02-16 14:21 UTC, Koike Kazuhiko 		none Details | Review
patch v4 (1.70 KB, patch)
2006-03-17 13:42 UTC, Koike Kazuhiko 		committed Details | Review

Description Thijs Vermeir 2005-12-17 20:11:51 UTC 
Like the Summary, all tracks have a bitrate of 0 KB/Second when looking in the
properties. The tracks are mostly mp3s and ogg.
Comment 1 Koike Kazuhiko 2006-01-10 13:40:03 UTC 
Created attachment 57104 [details] [review]
patch v1

(1) Changed the first argument of ComputeBitrate() from Seconds to TotalSeconds.
(2) Removed "filesize / 1000" in ComputeBitrate().

Ape/Util/MonkeyInfoReader.cs and Flac/Util/FlacInfoReader.cs also have
ComputeBitrate(), but I'm not sure they are wrong or not.
Comment 2 Koike Kazuhiko 2006-01-14 01:29:42 UTC 
Created attachment 57318 [details] [review]
patch v2

(1) MPEGFrame class returns bitrate in kilobit.
(2) bitrate should be divided by 1024 instead of 1000 when you want to display it
in kilobits
Comment 3 Thijs Vermeir 2006-01-23 13:12:25 UTC 
This patch looks like a good one.
I tested it only on MP3's and now the bitrate is correct.

Thanks,
Comment 4 Koike Kazuhiko 2006-02-16 14:21:27 UTC 
Created attachment 59494 [details] [review]
patch v3

(1) I thought 1 kilobits per second was 1024 bits per seconds. It's wrong.

(2) It's not necessary to divide "Bitrate" by 1024, because ComputeBitrate()
returns in kilobits per second.
Comment 5 Aaron Bockover 2006-03-14 22:32:28 UTC 
Ruben, can you look into this? Something tells me I resolved, this but am not sure.
Comment 6 Koike Kazuhiko 2006-03-17 13:42:38 UTC 
Created attachment 61440 [details] [review]
patch v4

This bug has not been resolved yet.
Comment 7 Ruben Vermeersch 2006-03-17 14:32:53 UTC 
(In reply to comment #5)
> Ruben, can you look into this? Something tells me I resolved, this but am not
> sure.

Experiencing the same thing as the submitter. Haven't tested patch yet though.
Comment 8 Ruben Vermeersch 2006-03-20 10:23:23 UTC 
Patch seems good, resolves the issue. Could go in if it were up to me.
Comment 9 Ruben Vermeersch 2006-04-06 10:52:11 UTC 
Tagging patch as accepted, more info on the why of it later.